! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
xfce4-diskperf-plugin-2.2.0: Bar colors not applied at plugin startup


Description Harald Judt 2007-04-26 22:51:16 CEST
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; de; rv: Gecko/20070403 Firefox/
Build Identifier: 

The disk performance plugin can be configured by using the configuration dialog. It will apply the new configuration after clicking on the close button and save the configuration to a config file. However, after restarting the panel or xfce the new configuration is not applied (except for device and label).

Reproducible: Always

Steps to Reproduce:
1. Set a different color than green in the gui configuration -> color changes.
2. Quit XFCE or the panel.
3. Restart XFCE or the panel.

Actual Results:  
1. Bar color is green.

Expected Results:  
2. Bar color should be anything else if green was not selected.

This happens only with the disk performance plugin, all other plugins work fine.
Same result on three different machines, all using gentoo distribution.
Disk performance monitor version: 2.1.0
Comment 1 Harald Judt 2007-04-26 22:56:40 CEST
Sorry, this actually *only* concerns the bar colors. The rest of the configuration options is read fine.
Comment 2 Harald Judt 2007-06-27 18:17:38 CEST
Created attachment 1272 
Fix for the configuration being read too late.

I've fixed the bug by myself, it is actually just one line in the diskperf_construct() function. While the configuration is read, it seems it is read too late (after the monitor bars have been created). With this patch, the configuration will be read before creation time so that the previously saved settings will be used.
Comment 3 Harald Judt 2009-10-12 10:36:24 CEST
This bug still exists in the newer version 2.2.0, and the patch still applies correctly.

Another solution to this issue has been provided in bug #3074.

It would be helpful if the developer could decide which version is the better one and include it in the next release, or fix it him/herself. Simply raising the version numbers without acknowledging the bug and applying the fix won't make it go away. Sorry for the rant, it works fine otherwise.
Comment 4 Florian Rivoal editbugs 2010-11-05 15:27:24 CET
Thanks for your patch. Both your patch and the one in 3074 look fine to me, but the patch for 3074 was already applied a while ago, so I won't use this one. This issue will be solved in the next release.

*** This bug has been marked as a duplicate of bug 3074 ***

Bug #3185

Reported by:
Harald Judt
Reported on: 2007-04-26
Last modified on: 2010-11-05


Xfce-Goodies Maintainers
CC List:
1 user


2.2.0 or older


Additional information