! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
exo-csource could strip the comments from a xml file
Status:
CLOSED: FIXED
Severity:
enhancement

Comments

Description Nick Schermer editbugs 2007-04-03 09:31:27 CEST
Currently when there are comments inside an XML document, those comments also end up in the generated string. So maybe exo-csource can remove the text between the <!-- comments --> (and maybe also the spaces, tabs and new lines between the xml >tags< ??), before generating the symbols file.
Comment 1 Nick Schermer editbugs 2007-04-05 17:34:38 CEST
Created attachment 1083 
exo-csource-strip-xml

This patch adds support for xml stripping in exo-csource. To use it, the user should should add the --strip-xml argument when parsing the xml file.
Comment 2 Nick Schermer editbugs 2007-04-05 17:41:01 CEST
Created attachment 1084 
thunar-strip-xml

Add support for xml stripping in Thunar. It saves about 4,6Kb in the binary (~1%) and hopefully improves the ui_manager speed a bit (for example: stripping the thunar-window-ui.xml makes it 26% smaller).
Comment 3 Benedikt Meurer editbugs 2007-05-20 11:18:35 CEST
Great idea, but you cannot simply drop characters between nodes. I'll modify that patch a little and commit it.
Comment 4 Benedikt Meurer editbugs 2007-05-20 11:50:48 CEST
Committed with revision 25728.

2007-05-20	Benedikt Meurer <benny@xfce.org>

	* exo-csource/main.c: Add support to strip comments and node contents
	  from XML files. Based on patch from Nick Schermer <nick@xfce.org>.
	  Bug #3094.
	* po/*.po, po/*.pot: Merge new strings.
	* po/de.po: Update german translations.

2007-05-20      Benedikt Meurer <benny@xfce.org>

        * thunar/Makefile.am: Strip unused characters from the user
          interface description files. Bug #3094.

Bug #3094

Reported by:
Nick Schermer
Reported on: 2007-04-03
Last modified on: 2009-10-09

People

Assignee:
Nick Schermer
CC List:
0 users

Version

Attachments

exo-csource-strip-xml (2.88 KB, patch)
2007-04-05 17:34 CEST , Nick Schermer
no flags
thunar-strip-xml (2.98 KB, patch)
2007-04-05 17:41 CEST , Nick Schermer
no flags

Additional information