! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Build failure on cygwin due to a missing file
Status:
RESOLVED: WONTFIX
Product:
Xfce-mcs
Component:
General

Comments

Description Darren Salt 2007-03-31 04:13:14 CEST
04:45:34 <Decepticon> well if it helps Ori_B_, here is the full output for when i do ./configure and then when i do make http://pastebin.ca/417779
04:48:06 <Decepticon> or anyone else that is willing to help :)
04:48:23 <_ds_> Tarball generation bug, I think.
04:48:59 <Ori_B_> Decepticon: care to try from svn?
04:49:07 <Decepticon> Ori_B_ im not sure what that is
04:50:25 <_ds_> ... yes, the file is indeed in svn.
04:51:01 <_ds_> Save http://svn.xfce.org/svn/xfce/xfce-mcs-manager/branches/xfce_4_4/xfce-mcs-manager/mcs-manager.def as xfce-mcs-manager/mcs-manager.def

Decepticon was building using cygwin. Significant bit from the above URL is this:

  make[2]: *** No rule to make target `mcs-manager.def', needed by `all-am'.  Stop.

This file is distributed iff HAVE_CYGWIN was defined at tarball generation time. This is normally wrong: if a file is needed on some supported system, it should always be distributed (unless you're building different source archives for different systems).

I believe that this patch (untested, except for running automake on the patched file) will fix this issue for freshly-generated tarballs.

--- xfce-mcs-manager/Makefile.am.orig	2007-03-31 04:52:09.000000000 +0100
+++ xfce-mcs-manager/Makefile.am	2007-03-31 05:04:51.000000000 +0100
@@ -11,9 +11,10 @@
 bin_PROGRAMS =								\
 	xfce-mcs-manager
 
+cygwin_files = mcs-manager.def
 if HAVE_CYGWIN
 develdir   = $(datadir)/xfce4/devel
-devel_DATA = mcs-manager.def
+devel_DATA = $(cygwin_files)
 endif
 
 xfce_mcs_manager_SOURCES =						\
@@ -52,12 +53,9 @@
 
 EXTRA_DIST = 								\
 	xfce-mcs-manager.pc.in						\
+	$(cygwin_files)							\
 	$(icons_DATA)
 
-if HAVE_CYGWIN
-EXTRA_DIST += $(devel_DATA)
-endif
-
 gtk_update_icon_cache = gtk-update-icon-cache -f -t $(datadir)/icons/hicolor
 
 install-data-hook:
Comment 1 Nick Schermer editbugs 2011-05-23 09:28:07 CEST
Close bugs in products that are not active anymore.

Bug #3085

Reported by:
Darren Salt
Reported on: 2007-03-31
Last modified on: 2011-05-23

People

Assignee:
Xfce Bug Triage
CC List:
0 users

Version

Attachments

Additional information