! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
No scrolling possible for 'Open With' dropdown box
Status:
RESOLVED: FIXED

Comments

Description Mathias Brodala 2007-03-25 17:34:43 CEST
User-Agent:       Opera/9.10 (X11; Linux i686; U; de)
Build Identifier: 

You cannot scroll to other entries in the dropdown box for 'Open With' in Thunar’s properties dialog. Since this is possible pretty much everywhere else in Thunar, it should be here too.

Reproducible: Always

Steps to Reproduce:
1. Go to properties page of any file
2. Try to change to another application by scrolling
3.

Actual Results:  
Thunar does not change to other applications.

Expected Results:  
Thunar should scroll through the list of available applications.
Comment 1 Nick Schermer editbugs 2008-12-01 07:43:36 CET
Jannis, did you try to implement ThunarChooserButton as a GtkComboBox or add signals for the scroll button?.
Comment 2 Jannis Pohlmann editbugs 2008-12-01 23:18:10 CET
(In reply to comment #1)
> Jannis, did you try to implement ThunarChooserButton as a GtkComboBox or add
> signals for the scroll button?.

What I tried was extending the ThunarChooserButton by connecting to the 'scroll-event' signal. Then I tried to cycle through the mime applications list. The main problem with that is that is only loaded on demand which makes things a bit difficult - still solvable I guess.
Comment 3 Nick Schermer editbugs 2008-12-02 07:36:52 CET
I think we also can make the widgets with a GtkComboBox as parent. Then Gtk provides all signals and atk stuff.
Comment 4 Nick Schermer editbugs 2008-12-03 18:22:19 CET
Created attachment 2013 
Patch

Created a patch, it seems to work...
Comment 5 Jannis Pohlmann editbugs 2008-12-03 18:39:08 CET
(In reply to comment #4)
> Created an attachment (id=2013) [details]
> Patch
> 
> Created a patch, it seems to work...

Yeah, works here too *but* the behaviour is kinda weird. That's not your fault though. The behaviour is just a bit unexpected. E.g. if you have a default application the first item is selected, and even though all other apps are listed *below* the selected item, you can scroll up to reach them.

I guess what I'd prefer is that the default application is just not made the first item in the list. I guess the main problem here is that applications are loaded on demand and thus the position of the default application can change. But then again, it is easy to find the position of the current item using g_list_find() or something like that.

Nick, if you have some time would you mind to give that a shot? I'm currently occupied with work stuff.
Comment 6 Nick Schermer editbugs 2008-12-06 17:01:59 CET
Created attachment 2019 
Implement as GtkComboBox

Another patch that implements the button as a combo box. Works nearly the same as the previous button apart from that the chooser dialog is not shown when you click with the mouse on the button and no default application is now.
Comment 7 Jannis Pohlmann editbugs 2010-11-13 16:06:22 CET
Fixed in master. Thanks Nick!

commit 15db96fff4be9dbc4b45372fda756274eac3e42b
Author: Jannis Pohlmann <jannis@xfce.org>
Date:   Sat Nov 13 16:04:28 2010 +0100

    Allow scrolling in the 'Open With' combo box (bug #3055).
    
    The open with button is now implemented as a subclass of GtkComboBox.
    The original patch for this was written by Nick. It had to be rewritten
    to apply against the new GIO codebase.
Comment 8 Mathias Brodala 2010-11-13 21:56:25 CET
(In reply to comment #7)
> Fixed in master. Thanks Nick!

Thanks a lot. :-)

Bug #3055

Reported by:
Mathias Brodala
Reported on: 2007-03-25
Last modified on: 2010-11-13

People

Assignee:
Jannis Pohlmann
CC List:
2 users

Version

Version:
0.5.0rc2

Attachments

Patch (8.99 KB, patch)
2008-12-03 18:22 CET , Nick Schermer
no flags
Implement as GtkComboBox (28.39 KB, patch)
2008-12-06 17:01 CET , Nick Schermer
no flags

Additional information