! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Files get truncated on copy when destination medium full
Status:
RESOLVED: MOVED

Comments

Description laurent pichler 2007-03-13 10:50:11 CET
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; de-DE; rv:1.8.0.10) Gecko/20070302 Firefox
Build Identifier: 

I discovered this bug when copying multiple files at once (or a single too big file) to my USB Stick. 
Thunar seems not to check if there is enough space left on the dest. volume and copies files incompletely instead of refusing to copy them at all.

Sometimes it also leaves files with zero size.

This bug is not always triggered. I was able to reproduce it multiple times, though.

Reproducible: Sometimes
Comment 1 Julien [nodiscc] editbugs 2011-01-11 12:45:06 CET
I'd like to add that, when copying large files (over 4GB) to a filesystem that doesn't support it (eg FAT32), Thunar tries to copy the files anyway, then shows an error when the maximum size is reached. It leaves a 4,0 GB incomplete file on the destination drive.

Considering the first report, I think it should:
-check the free space on destination drive against the size of files being copied.
-check the destination filesystem's support for large files before copying them.
-prompt the user to skip, abort... if problems are ahead.
-remove incomplete files resulting from these errors, or at least mark them with something like _INCOMPLETE.

Thanks
Comment 2 Jannis Pohlmann editbugs 2011-01-11 13:44:19 CET
(In reply to comment #1)
> Considering the first report, I think it should:
> -check the free space on destination drive against the size of files being
> copied.

Benny has explained this quite a few times: this check is not reliable. The used disk space can change any time before, during or after the copy operation. 

> -check the destination filesystem's support for large files before copying
> them.

That definitely makes sense but I suppose this check belongs into GIO or GVfs. It should be added to operations like g_file_copy() and g_file_copy_async() and if not supported, the GError return parameter should be set, so we can do:

> -prompt the user to skip, abort... if problems are ahead.
> -remove incomplete files resulting from these errors, or at least mark them
> with something like _INCOMPLETE.
Comment 3 Harald Judt editbugs 2015-04-17 20:42:11 CEST
*** Bug 7812 has been marked as a duplicate of this bug. ***
Comment 4 Git Bot editbugs 2020-05-26 23:05:16 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/thunar/-/issues/4.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #3004

Reported by:
laurent pichler
Reported on: 2007-03-13
Last modified on: 2020-05-26
Duplicates (1):
  • 7812 Canceled or interrupted file copy leaves leaves incomplete files

People

Assignee:
Jannis Pohlmann
CC List:
3 users

Version

Attachments

Additional information