Comment 1 Benedikt Meurer 2007-01-12 09:36:24 CET

Hm, just tested this uncommenting the if (sizeof(GType) == sizeof(gint)) optimization, so using the code path for your platform, but I can't reproduce that. Each view is assigned a unique index, so that should work. Add a line to thunar_window_action_view_changed()

   g_message ("type=%s, index=%d", g_type_name (type),
       gtk_radio_action_get_current_value (action));

after the line saying

 type = view_index2type (gtk_radio_action_get_current_value(....));

and post the output of changing views, that may help to trace the problem.

I applied the changes and it generated the following warning/messages:

---------------------- START ----------------------
[willi@jericho Webilder-0.6]$ thunar 
Thunar-Message: type=ThunarIconView, index=538233248

(thunar:3572): Gtk-WARNING **: Theme directory scalable/emblems of theme Flat-Blue has no size field

Thunar-Message: type=ThunarIconView, index=538236512
Thunar-Message: type=ThunarIconView, index=538223600
[willi@jericho Webilder-0.6]$ thunar 
Thunar-Message: type=ThunarIconView, index=538233248

(thunar:3578): Gtk-WARNING **: Theme directory scalable/emblems of theme Flat-Blue has no size field

----------------------- END -----------------------

The first msg of ... index=53/8236512 was immediately after opening and going to 'detailed view'

The second is when changing the setting to 'compact view'

The third, index=538233248 was after closing and reopening in 'compact view' and having thunar revert back to 'icon view' on start...

Comment 3 Benedikt Meurer 2007-01-13 14:25:32 CET

Do you use the latest revision from SVN? Or do you use your own patched version? In that case, please verify that your patch really matches mine, because according to your output, the type is not properly translated to an index (i.e. view_type2index not called appropriately), and so view_index2type runs into the default case, which is the icon view.

Na I don't have the SVN release, instead I downloaded 0.5.0rc2 and then applied the changes that you specified. I'll go ahead and try the SVN release and see what it does... Get back with you in a bit...

Well, downloaded the latest SVN and managed to make my way up to the error below... For one reason another, the build failed to check for some dependencies such as LIBSEXY. I thinking the error below is related to XFCE:


ccache gcc-4.0.1 -ggdb -O3 -finline -fstrict-aliasing -fomit-frame-pointer -w -pipe -finline-functions -finline-limit=1200 -mieee -mtune=pca56 -Wl,-lots -Wl,--as-needed -o .libs/Thunar -Wl,-O1 Thunar-thunar-marshal.o Thunar-main.o Thunar-thunar-abstract-dialog.o Thunar-thunar-abstract-icon-view.o Thunar-thunar-application.o Thunar-thunar-chooser-button.o Thunar-thunar-chooser-dialog.o Thunar-thunar-chooser-model.o Thunar-thunar-clipboard-manager.o Thunar-thunar-column-editor.o Thunar-thunar-column-model.o Thunar-thunar-compact-view.o Thunar-thunar-component.o Thunar-thunar-create-dialog.o Thunar-thunar-debug.o Thunar-thunar-details-view.o Thunar-thunar-dialogs.o Thunar-thunar-dnd.o Thunar-thunar-emblem-chooser.o Thunar-thunar-enum-types.o Thunar-thunar-file.o Thunar-thunar-file-monitor.o Thunar-thunar-folder.o Thunar-thunar-gdk-extensions.o Thunar-thunar-gobject-extensions.o Thunar-thunar-gtk-extensions.o Thunar-thunar-history-action.o Thunar-thunar-history.o Thunar-thunar-ice.o Thunar-thunar-icon-factory.o Thunar-thunar-icon-renderer.o Thunar-thunar-icon-view.o Thunar-thunar-launcher.o Thunar-thunar-list-model.o Thunar-thunar-location-bar.o Thunar-thunar-location-button.o Thunar-thunar-location-buttons.o Thunar-thunar-location-dialog.o Thunar-thunar-location-entry.o Thunar-thunar-metafile.o Thunar-thunar-navigator.o Thunar-thunar-pango-extensions.o Thunar-thunar-path-entry.o Thunar-thunar-permissions-chooser.o Thunar-thunar-preferences-dialog.o Thunar-thunar-preferences.o Thunar-thunar-progress-dialog.o Thunar-thunar-properties-dialog.o Thunar-thunar-renamer-dialog.o Thunar-thunar-renamer-model.o Thunar-thunar-renamer-pair.o Thunar-thunar-renamer-progress.o Thunar-thunar-sendto-model.o Thunar-thunar-session-client.o Thunar-thunar-shortcuts-icon-renderer.o Thunar-thunar-shortcuts-model.o Thunar-thunar-shortcuts-pane.o Thunar-thunar-shortcuts-view.o Thunar-thunar-side-pane.o Thunar-thunar-size-label.o Thunar-thunar-standard-view.o Thunar-thunar-statusbar.o Thunar-thunar-stock.o Thunar-thunar-templates-action.o Thunar-thunar-text-renderer.o Thunar-thunar-throbber.o Thunar-thunar-throbber-fallback.o Thunar-thunar-thumbnail-frame.o Thunar-thunar-thumbnail-generator.o Thunar-thunar-trash-action.o Thunar-thunar-tree-model.o Thunar-thunar-tree-pane.o Thunar-thunar-tree-view.o Thunar-thunar-util.o Thunar-thunar-view.o Thunar-thunar-window.o Thunar-xfce-heading.o Thunar-xfce-titled-dialog.o  -L/usr/X11R6/lib ../tdb/.libs/libtdb.a ../thunar-vfs/.libs/libthunar-vfs-1.so /usr/lib/libjpeg.so -lpng12 -lz /usr/lib/libstartup-notification-1.so ../thunarx/.libs/libthunarx-1.so /usr/lib/libexo-0.3.so /usr/lib/libgtk-x11-2.0.so /usr/lib/libxfce4util.so /usr/lib/libgdk-x11-2.0.so /usr/lib/libatk-1.0.so /usr/lib/libgdk_pixbuf-2.0.so /usr/lib/libpangoxft-1.0.so /usr/lib/libpangox-1.0.so /usr/lib/libpangoft2-1.0.so /usr/lib/libpango-1.0.so -lm /usr/lib/libgobject-2.0.so /usr/lib/libgmodule-2.0.so -pthread /usr/lib/libgthread-2.0.so -lpthread /usr/lib/libglib-2.0.so /usr/X11R6/lib/libSM.so /usr/X11R6/lib/libICE.so /usr/X11R6/lib/libX11.so /usr/X11R6/lib/libXau.so -ldl
Thunar-thunar-preferences-dialog.o: In function `thunar_preferences_dialog_init':
/usr2/www/linux-related/desktop/xfce-4/xfce-4.4/source/tmp/thunar/thunar-preferences-dialog.c:613: undefined reference to `sexy_url_label_new'
/usr2/www/linux-related/desktop/xfce-4/xfce-4.4/source/tmp/thunar/thunar-preferences-dialog.c:613: undefined reference to `sexy_url_label_new'
/usr2/www/linux-related/desktop/xfce-4/xfce-4.4/source/tmp/thunar/thunar-preferences-dialog.c:618: undefined reference to `sexy_url_label_set_markup'
/usr2/www/linux-related/desktop/xfce-4/xfce-4.4/source/tmp/thunar/thunar-preferences-dialog.c:618: undefined reference to `sexy_url_label_set_markup'
../thunar-vfs/.libs/libthunar-vfs-1.so: undefined reference to `g_list_free1'
collect2: ld returned 1 exit status
make[3]: *** [Thunar] Error 1
make[3]: Leaving directory `/usr2/www/pub/alpha-RH7/desktop/xfce-4/xfce-4.4/source/tmp/thunar'
make[2]: *** [all] Error 2
make[2]: Leaving directory `/usr2/www/pub/alpha-RH7/desktop/xfce-4/xfce-4.4/source/tmp/thunar'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/usr2/www/pub/alpha-RH7/desktop/xfce-4/xfce-4.4/source/tmp'
make: *** [all] Error 2

Had to edit the makefile to link to libsexy... now here's the 'real' error msg:

collect2: ld returned 1 exit status
make[3]: *** [Thunar] Error 1
make[3]: Leaving directory `/usr2/www/pub/alpha-RH7/desktop/xfce-4/xfce-4.4/source/tmp/thunar'
make[2]: *** [all] Error 2
make[2]: Leaving directory `/usr2/www/pub/alpha-RH7/desktop/xfce-4/xfce-4.4/source/tmp/thunar'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/usr2/www/pub/alpha-RH7/desktop/xfce-4/xfce-4.4/source/tmp'
make: *** [all] Error 2

whoops, forgot the first line:

../thunar-vfs/.libs/libthunar-vfs-1.so: undefined reference to `g_list_free1'

Comment 8 Benedikt Meurer 2007-01-14 09:50:44 CET

The SexyUrlLabel class is included with Thunar (the thunar/sexy-url-label.{c,h} files), so you don't need to link to libsexy (dunno why it fails for you).

The g_list_free1() is a GLib macro for g_list_free_1(). Dunno why GLib doesn't define that for you. I replaced that with g_list_free_1() now. svn up.

Comment 9 Nick Schermer 2012-09-30 08:30:02 CEST

Please reopen if this is still an issue with the latest Thunar release.