! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Fix xfce4-genmon to compile with LDFLAGS="-Wl,--as-needed" and autotools bork...
Status:
RESOLVED: FIXED
Product:
Xfce4-genmon-plugin
Component:
General

Comments

Description Samuli Suominen 2007-01-07 08:38:20 CET
Patch is at http://bugs.gentoo.org/attachment.cgi?id=105689 to fix compilation error, and after that it needs to run full set of autotools to provide needed files including xdt-autogen, intltoolize --automake --copy --force because the files are simply not there.

diff -ur xfce4-genmon-plugin-3.0.orig/panel-plugin/Makefile.am xfce4-genmon-plugin-3.0/panel-plugin/Makefile.am
--- xfce4-genmon-plugin-3.0.orig/panel-plugin/Makefile.am	2006-10-13 19:08:29.000000000 +0300
+++ xfce4-genmon-plugin-3.0/panel-plugin/Makefile.am	2007-01-06 20:51:04.000000000 +0200
@@ -5,7 +5,7 @@
 	-DPACKAGE_LOCALE_DIR=\"$(localedir)\"			\
 	@LIBXFCE4PANEL_CFLAGS@
 
-xfce4_genmon_plugin_LDFLAGS =					\
+xfce4_genmon_plugin_LDADD =					\
 	@LIBXFCE4PANEL_LIBS@
 
 xfce4_genmon_plugin_SOURCES =	\
Comment 1 Nick Schermer editbugs 2007-01-09 18:26:54 CET
Fix in revision 2325.
Comment 2 Samuli Suominen 2007-01-10 14:52:58 CET
Thanks for committing!

Can you please run "xdg-autogen" and "intltoolize --automake --copy --force" because trunk is missing files like intltool-extract.in, intltool-merge.in, intltool-update.in, po/Makefile.in.in..

Be noted that they come with other plugins.

Thanks, Samuli
Comment 3 Samuli Suominen 2007-01-10 14:55:11 CET
Oops, perhaps they shouldn't be in trunk after all but just in tarball?
Comment 4 Nick Schermer editbugs 2007-01-11 08:05:01 CET
autogen will create them and they are in Makefile.am, so they will be distributed with the tarball. Those files don't belong in trunk.
Comment 5 Samuli Suominen 2007-01-11 15:51:29 CET
(In reply to comment #4)
> autogen will create them and they are in Makefile.am, so they will be
> distributed with the tarball. Those files don't belong in trunk.
> 

Okay, since some files was missing from last tarball.. be reminded to check those mentioned files when creating tarballing next release.

Bug #2722

Reported by:
Samuli Suominen
Reported on: 2007-01-07
Last modified on: 2011-02-24

People

Assignee:
Florian Rivoal
CC List:
1 user

Version

Version:
3.2 or older
Target Milestone:
3.2 or older

Attachments

Additional information