User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.1) Gecko/20061224 Firefox/2.0.0.1 Build Identifier: Using mrxvt (multi-session/windowed rxvt), xfce4-session cannot correctly restore this app between sessions because the invocation line for mrxvt already uses commas. So "mrxvt -ip 0,1,2,3" is the way I need to invoke mrxvt to restore my profiles for windows 0, 1, 2, and 3. However xfce4-session in .cache/session/xfce4-session-machinename:0 saves that commandline as: "Client0_RestartCOmmand=mrxvt,-ip,0,1,2,3,-desktop,0,-geometry,132x55+80+8,-km,NOENC,-sm,-sid,hexdigitshere but that is incorrect as it really needs to be: 'mrxvt','-ip','0,1,2,3','-desktop',... With xfce4-session passing 'mrxvt','-ip','0','1','2','3' the mrxvt app correctly responds with no such command 1, no such command 2, no such command 3. I'm sure other gui-apps can or will also pass cmdline args where some parameters are seperated by commas and then whitespace. This behavior in xfce4-session needs some sort of modification to allow for those apps that have already decided to use commas in their own cmdline args. Reproducible: Always Steps to Reproduce: 1. invoke "mrxvt -ip 0,1,2,3" from Run program dialog box 2. End session using Quit button on xfce4-panel 3. Restart xfce4 and watch mrxvt not be restored, error messages get sent to linux console where startxfce4 was invoked from. Actual Results: mrxvt says something to the effect of "no such command 1" and then "no such command 2" and then "no such command 3" and then no mrxvt app is started at all. Expected Results: "mrxvt -ip 0,1,2,3" should open the mrxvt app with 4 windowed/sessions started up.
Should just escape commas in list items inside xfce_rc_write_list_entry() and unescape them in xfce_rc_read_list_entry(). But I'm not sure how to do this best without breaking existing apps. Will need to look into the code to see if we're escaping anything already...
Yeah, changing the separator would break all existing session files without some kind of migration in place. Probably can't do this in time for beta2. Maybe rc1.
Reassign to xfce-bugs@xfce.org.
-- GitLab Migration Automatic Message -- This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/xfce4-session/-/issues/1. Please create an account or use an existing account on one of our supported OAuth providers. If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev