this new dbus-binding-tool behaviour breaks plugins/thunar-tpa from the Makefile.am --- thunar-tpa-bindings.h: $(srcdir)/thunar-tpa-bindings.xml Makefile dbus-binding-tool --mode=glib-client $(srcdir)/thunar-tpa-bindings.xml > thunar-tpa-bindings.h endif --- essentially sth like --prefix=thunar_tpa_icon should be added... it seems that xfdesktop is also broken, but I'll open a new bug for it...
hm --prefix=org_xfce_Trash seems to be the correct one (strange the previous one somehow worked)...
Created attachment 866 Suggested fix The prefix doesn't seem to be used for glib-client mode.
(In reply to comment #2) > The prefix doesn't seem to be used for glib-client mode. > Yes, no matter what it is fed with, it seems to create the same header, I probably should go and file bug against dbus-binding-tool, as this most probably is not the desired behaviour... Should I file a separate bug for xfdesktop? also this is the patch I use in the moment for it (well probably with incorrect prefix :) ): Index: src/Makefile.am =================================================================== --- src/Makefile.am (revision 23763) +++ src/Makefile.am (working copy) @@ -113,10 +113,10 @@ xfdesktop-dbus-bindings-trash.h xfdesktop-dbus-bindings-filemanager.h: $(srcdir)/xfdesktop-dbus-bindings-filemanager.xml Makefile - dbus-binding-tool --mode=glib-client $(srcdir)/xfdesktop-dbus-bindings-filemanager.xml > xfdesktop-dbus-bindings-filemanager.h + dbus-binding-tool --prefix=org_xfce_Thrash --mode=glib-client $(srcdir)/xfdesktop-dbus-bindings-filemanager.xml > xfdesktop-dbus-bindings-filemanager.h xfdesktop-dbus-bindings-trash.h: $(srcdir)/xfdesktop-dbus-bindings-trash.xml Makefile - dbus-binding-tool --mode=glib-client $(srcdir)/xfdesktop-dbus-bindings-trash.xml > xfdesktop-dbus-bindings-trash.h + dbus-binding-tool --prefix=org_xfce_FileManager --mode=glib-client $(srcdir)/xfdesktop-dbus-bindings-trash.xml > xfdesktop-dbus-bindings-trash.h endif endif
Yes, file a separate one for xfdesktop.
Committed with revision 23820. 2006-11-11 Benedikt Meurer <benny@xfce.org> * plugins/thunar-tpa/Makefile.am: Starting with version 0.72 dbus-binding-tool now requires the --prefix command line option even though it isn't used for anything. Bug #2528.