! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
--enable-kde-systray failes to build with RC2


Description Bernhard Walle 2006-11-05 23:12:57 CET
See subject. :)

I tried a patch, don't know if it's 100 % correct. See attachment.
Comment 1 Bernhard Walle 2006-11-05 23:13:46 CET
Created attachment 849 
Patch that should fix the issue
Comment 2 Scott Jones 2006-11-06 06:27:33 CET
I was just about to report this to you, Bernhard.  It builds OK with your patch, but any KDE apps in the systray have an icon about 2 px. wide on my monitor.  SUSE 10.1, KDE 3.5.5 from buildservice, Xorg 7.2 from buildservice.  I'm going to check with a stock installation once I get it installed in VMware.
Comment 3 Olivier Fourdan editbugs 2006-11-06 10:17:12 CET
The KDE systray is really meant to go. KDE has switched to the standard EWMH systray, there is no reason to keep support for something that even KDE has dropped.

The 2pix wide icon is because we have also removed the hack that forced the size of the icons in the systray widget.

I'm not sure about the patch, though, since myDisplayGetCurrentTime() is still valid. 
Comment 4 Olivier Fourdan editbugs 2006-11-06 11:35:03 CET
I think the patch is correct and should work, though.
Comment 5 Olivier Fourdan editbugs 2006-11-06 22:14:32 CET
Should be fixed with rev. 23766
Comment 6 Bernhard Walle 2006-11-06 23:21:12 CET
Package in the openSUSE build Service should be fixed (should be in sync in a few hours). If not, please don't reopen this bug but report to bwalle@suse.de. Thanks.
Comment 7 Olivier Fourdan editbugs 2006-11-07 16:54:02 CET
Unfortunately, my commit has introduced a nasty bug. I'll post a fix later tonight. Sorry about the inconvenient this may cause.
Comment 8 Olivier Fourdan editbugs 2006-11-08 09:02:28 CET
The fix to the fix was committed last night, resolving.
Comment 9 Olivier Fourdan editbugs 2006-11-08 09:02:47 CET
Comment 10 Bernhard Walle 2006-11-08 20:30:28 CET
Only for Scott Jones: Backported in openSUSE Build Service.

Bug #2511

Reported by:
Bernhard Walle
Reported on: 2006-11-05
Last modified on: 2009-07-14


Olivier Fourdan
CC List:
1 user



Patch that should fix the issue (579 bytes, patch)
2006-11-05 23:13 CET , Bernhard Walle
no flags

Additional information