! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Thunar icon zone space and word wraping
Status:
CLOSED: FIXED

Comments

Description Mindaugas 2006-11-05 17:53:19 CET
User-Agent:       Opera/9.02 (X11; Linux i686; U; en)
Build Identifier: 

At first, the default Thunar's icon size is too huge. Personally, I need to press CTRL + - two times to zoom our for usable size. This, of course, is personal dependent option, but I think in most cases default icon size should be more less - it would be better for the first impression of user.
The second, even minimized icons has quite a long spaces between each other. Especially it looks very bad with long file names. For this reason, there must be implemented word wraping for the file names and, I think, more stricted space control between icons. Icons looks better when they are in comfortable "grid".
IMHO it is very important to implement before widely-use release.

Reproducible: Always

Steps to Reproduce:
-
Comment 1 Benedikt Meurer editbugs 2006-11-05 20:54:51 CET
You know that you can adjust the icon spacing? See bug #1698.
Comment 2 Mindaugas 2006-11-06 13:21:26 CET
No, I didn't knew that. It is a useful feature, for users would be good if it could be adjustable via Preferences ;)
But the name wraping should be implemented too, long names are spoiling the spaces.

Thanks.
Comment 3 Benedikt Meurer editbugs 2006-11-06 18:24:10 CET
(In reply to comment #2)
> No, I didn't knew that. It is a useful feature, for users would be good if it
> could be adjustable via Preferences ;)

It is already adjustable. No need to add a mostly useless option to the preferences dialog (because 99.99% of the user stay with the sane defaults here).

> But the name wraping should be implemented too, long names are spoiling the
> spaces.

File names are currently word-wrapped at 128px.
Comment 4 Benedikt Meurer editbugs 2006-11-06 18:58:05 CET
Created attachment 857 
Possible patch

Maybe this patch does what you want.
Comment 5 Mindaugas 2006-11-06 19:44:33 CET
Yes, wraping by zoom level looks much better. But it is needed to wrap height too. Could this be done? Thanks.
Comment 6 Benedikt Meurer editbugs 2006-11-06 19:46:09 CET
Wrap height and width? Besides voodoo magic, how should that be implemented? ;-)
Comment 7 Mindaugas 2006-11-06 19:49:02 CET
> But it is needed to wrap height too.
By the way, for this would be great to have a tooltip with full name, which appears when keeping mouse over the icon.
Comment 8 Benedikt Meurer editbugs 2006-11-06 19:53:12 CET
Ah, you're talking about ellipsizing! The way it's done in i.e. Windows Explorer. Well, for usability reasons, this is not done in Thunar, because you have no chance to see several long file names at once, which clearly reduces the usability. This feature comes at the cost of some wasted space, unless you have really long file names, this only up to 1 or 2 lines per row, so nothing to worry about, atleast it's not worth to break usabilty.
Comment 9 Mindaugas 2006-11-06 21:03:14 CET
> Ah, you're talking about ellipsizing!
Sorry for naming, I am not very familiar with GUI programming :)
> The way it's done in i.e. Windows Explorer.
Yes, exactly like Windows Explorer does. It is simply convenient (if it wouldn't, Explorer team wouldn't do this) and looks good, when using the icons view.
> Well, for usability reasons, this is not done in Thunar, because you
> have no chance to see several long file names at once
1. There is allways a solution for that - make a feature choicable (a simple tick in Preferences).
2. I think it would be good to do it only for icons mode. Detailed (purpose of this to be informative) and compact list mode could (and should!) be as now. I don't think it is so wrong.
Comment 10 Benedikt Meurer editbugs 2006-11-06 22:46:32 CET
(In reply to comment #9)
> > The way it's done in i.e. Windows Explorer.
> Yes, exactly like Windows Explorer does. It is simply convenient (if it
> wouldn't, Explorer team wouldn't do this) and looks good, when using the icons
> view.

Err, you're kidding, right? ;-)

The Windows team made a lot of mistakes wrt user interface design...

> > Well, for usability reasons, this is not done in Thunar, because you
> > have no chance to see several long file names at once
> 1. There is allways a solution for that - make a feature choicable (a simple
> tick in Preferences).
> 2. I think it would be good to do it only for icons mode. Detailed (purpose of
> this to be informative) and compact list mode could (and should!) be as now. I
> don't think it is so wrong.

Well, we decided against it for good reasons (usability > featurities, yannow). And it's too late for the final to discuss/change that again. You can file a separate feature request for 2.0.0final.
Comment 11 Mindaugas 2006-11-06 23:14:49 CET
> The Windows team made a lot of mistakes wrt user interface design...
Of course they made mistakes, like all of us. But talking about user-friendly GUI, they allways knew what user wants and open-source can learn many things from them about realizing users' needs.
Ironical, but this saying a long time Fluxbox user! :)

> Well, we decided against it for good reasons (usability > featurities, yannow).
I understand, but making it a choicable feature (for eg. disabled by default) doesn't break any usability, does it?

> And it's too late for the final to discuss/change that again. You can file a
> separate feature request for 2.0.0final.
Could we simply change the target of this report to 2.0.0final?
Comment 12 Benedikt Meurer editbugs 2006-11-10 19:11:43 CET
One bug report per issue.
Comment 13 Benedikt Meurer editbugs 2006-11-11 13:11:52 CET
Committed with revision 23823.

2006-11-11	Benedikt Meurer <benny@xfce.org>

	* thunar/thunar-icon-view.c: Set word-wrap-width depending on the
	  current zoom-level. Bug #2505.

Bug #2505

Reported by:
Mindaugas
Reported on: 2006-11-05
Last modified on: 2009-07-17

People

Assignee:
Jannis Pohlmann
CC List:
0 users

Version

Version:
0.5.0rc2

Attachments

Possible patch (3.03 KB, patch)
2006-11-06 18:58 CET , Benedikt Meurer
no flags

Additional information