! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
configure script needs to be smarter about thunar-vfs + dbus


Description Brian J. Tarricone (not reading bugmail) 2006-09-19 20:32:37 CEST
Right now, configure will fail if thunar-vfs is found but dbus is not.  In this case, configure should succeed, but disable file/launcher icons.

1.  Move the dbus check out of the condition, and change it to an optional depend.
2.  Add a config.h #define for ENABLE_FILE_ICONS, which is set only if THUNAR_VFS_FOUND and DBUS_FOUND are both 'yes'.
Comment 1 Robby Workman editbugs 2006-09-19 21:06:49 CEST
Brian, if I understand this correctly, it will disable all desktop icons if dbus is not present, right?  I know in beta2 the icons were available without dbus, and it seems that the changes associated with the new Trash icon are what actually need both dbus and thunar-vfs.  Ultimately, it doesn't matter much to me, as I don't use the desktop icons anyway, but from a packaging standpoint, it's important to me.  :)
Comment 2 Brian J. Tarricone (not reading bugmail) 2006-09-19 21:33:53 CEST
No, no dbus will just disable file/launcher icons.  Minimised app icons will still be there.  I converted (or was in the process of converting) a bunch of non-trash stuff that just used dbus-send to use libdbus directly, hence the need for the dependency.
Comment 3 Brian J. Tarricone (not reading bugmail) 2006-09-28 19:23:14 CEST
Ok, this should be fixed with rev 23236.  From my commit message:

ok, this should fix annoying build problems (bug 2344). here's how the
dependencies work:

no icons at all:
* (no external deps beyond what's normal)

minimised app icons:
* exo (optional, for icon effects)

file/launcher icons:
* thunar-vfs
* dbus
* thunarx (optional, for thunar plugin support)
* exo (optional, for icon effects)

relevant build options:

by default, the configure script will check for everything and enable
everything if it's available. otherwise:

--disable-desktop-icons: disables all desktop icons
--disable-file-icons: disables file/launcher icons, but minimised app icons
are still present
--disable-exo: disables using exo for some icon effects (note: i believe
thunar-vfs pulls in libexo anyway, so if file/launcher icons
are enabled, there's really no reason to disable exo except
maybe performance reasons)
--disable-thunarx: disables using thunarx to load thunar plugins

Bug #2344

Reported by:
Brian J. Tarricone (not reading bugmail)
Reported on: 2006-09-19
Last modified on: 2009-07-14


Brian J. Tarricone (not reading bugmail)
CC List:
2 users



Additional information