2336 – Use the EXO icon chooser in launcher

Use the EXO icon chooser in launcher

Status:

RESOLVED: FIXED

Priority:
Medium

Severity:
enhancement

Product:
Xfce4-panel

Component:

Panel

Comments

Description Nick Schermer editbugs

2006-09-18 12:41:41 CEST

This is a quick hack to add the exo icon chooser into the launcher properties dialog (demo patch).

Advantages:
* A _lot_ of code is removed from the launcher-dialog.c.
* Easy icon choosing.
* Entry structure can (should) be simplified: Drop the LauncherIcon structure and LauncherIconType enum. Add the gchar *icon_name to LauncherEntry instead.
* 15 translator strings dropped.

Disadvantages:
* Panel will (optionally) depend on EXO. (I don't think we should make it optionally).
* A lot of launcher code should be rewritten. I can do that :-).
* New string for translators .

So, probably something for the 4.6 TODO list.

Comment 1 Nick Schermer editbugs

2006-09-18 12:42:07 CEST

Created attachment 800 
Sample path

Comment 2 Nick Schermer editbugs

2006-09-18 12:43:48 CEST

Created attachment 801 
Patch

A diff file this time...

Comment 3 Nick Schermer editbugs

2006-09-18 12:44:35 CEST

Created attachment 802 
Screenshot

Comment 4 Jasper Huijsmans editbugs

2006-09-18 18:19:26 CEST

Definitely after 4.4.0. Maybe we can do it for 4.4.x. I wouldn't like to have to wait another year or so...

Comment 5 Nick Schermer editbugs

2006-12-21 08:48:51 CET

It's mine baby!

Comment 6 Nick Schermer editbugs

2007-03-03 19:38:03 CET

Imported in trunk.

Bug #2336

Reported by:
Nick Schermer

Reported on: 2006-09-18
Last modified on: 2010-11-20

People

Assignee:
Nick Schermer

CC List:
0 users

Version

Version:
4.4.x

Target Milestone:
Panel Old

Attachments

Sample path (103.05 KB, patch) 2006-09-18 12:42 CEST , Nick Schermer	no flags
Patch (15.66 KB, patch) 2006-09-18 12:43 CEST , Nick Schermer	no flags
Screenshot (73 bytes, text/plain) 2006-09-18 12:44 CEST , Nick Schermer	no flags

Additional information