! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
make dist-bzip2 fails
Status:
CLOSED: FIXED

Comments

Description Jani Monoses 2006-09-12 13:53:38 CEST
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.4) Gecko/20060508 Firefox/1.5.0.4
Build Identifier: 

on ubuntu edgy, creating the tar part of make dist-bzip2 fails with
tar: Thunar-0.4.1svn-r23130/docs/reference/thunarx/html/thunarx-Variables-and-functions-to-check-the-library-version.html: file name is too long (max 99); not dumped

looks like the -o option passed to tar, which makes a V7 format tar archive cannot handle long names.


Reproducible: Always
Comment 1 Benedikt Meurer editbugs 2006-09-12 14:43:08 CEST
Hm, works fine on FreeBSD. But that's definitely an automake issue, not a Thunar one, because the dist/dist-bzip2 targets are generated by automake.
Comment 2 Jani Monoses 2006-09-12 14:52:01 CEST
ok, I thought some custom autotools macros from xfce-dev may have been involved. I'll bring this up in with automake in ubuntu. thanks.
Comment 3 Jani Monoses 2006-09-13 15:20:39 CEST
I'm back. Looks like there's an option in automake (>=1.9) to tell it to use the
ustar format instead of v7 by default.

mentioned in  Portability improvements section in this page
http://sources.redhat.com/ml/automake/2004-05/msg00144.html

could it be that on FreeBSD you are not using GNU tar and that has different defaults?
Also googling for automake tar v7 (or info automake) turns something up but I am not sure if projects themselves need to tell automake to use a different format or should it use fallbacks itself.

Comment 4 Benedikt Meurer editbugs 2006-09-13 15:56:02 CEST
FreeBSD uses bsdtar (based on libarchive), which defaults to ustar - well actually pax is preferred, but as with everything, old habits... :-).

So, does adding tar-ustar to AUTOMAKE_OPTIONS fix the problem for you?
Comment 5 Jani Monoses 2006-09-13 16:17:38 CEST
I have tried now that you ask, and it does not. Looks like this option cannot go there only directly to AM_INIT_AUTOMAKE in configure.in.in as it is global.
However that means it has to use the new and not the deprecated (as of 1.9 at least) version of this macro, so the one with [options] not (package,version)
So putting it in there the dist-bzip2 target is ok.


Index: configure.in.in
===================================================================
--- configure.in.in     (revision 23131)
+++ configure.in.in     (working copy)
@@ -38,7 +38,7 @@
 dnl ***************************
 dnl *** Initialize automake ***
 dnl ***************************
-AM_INIT_AUTOMAKE([AC_PACKAGE_TARNAME()], [AC_PACKAGE_VERSION()])
+AM_INIT_AUTOMAKE([tar-ustar])
 AM_CONFIG_HEADER([config.h])
 AM_MAINTAINER_MODE()
Comment 6 Benedikt Meurer editbugs 2006-09-13 16:53:03 CEST
The option should go into Makefile.am -> AUTOMAKE_OPTIONS.
Comment 7 Benedikt Meurer editbugs 2006-09-13 16:58:09 CEST
Err, ups, I should have read the whole text. ;-)

So, basicly, the option(s) would need to be added to configure.in.in and Makefile.am will not work?
Comment 8 Jani Monoses 2006-09-13 17:21:57 CEST
it did not work in Makefile.am, it may be one of the options which needs to affect all makefiles? Don't ask me though, you're the autotools expert ;)
snip from autogen output

Running automake-1.9 --add-missing --copy --gnu...
Makefile.am:17: option `tar-ustar' must be an argument of AM_INIT_AUTOMAKE
Comment 9 Benedikt Meurer editbugs 2006-09-13 18:12:29 CEST
Fixed with revision 23144.

2006-09-13	Benedikt Meurer <benny@xfce.org>

	* configure.in.in, Makefile.am: Place automake options into
	  configure.in.in instead of Makefile.am and add the tar-ustar
	  option to fix building distributions on system where tar defaults
	  to the deprecated V7 format. Bug #2304.

Bug #2304

Reported by:
Jani Monoses
Reported on: 2006-09-12
Last modified on: 2009-07-17

People

Assignee:
Jannis Pohlmann
CC List:
0 users

Version

Version:
0.4.1svn

Attachments

Additional information