! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
sometimes opens twice
Status:
CLOSED: FIXED

Comments

Description Jani Monoses 2006-08-31 14:00:26 CEST
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.4) Gecko/20060508 Firefox/1.5.0.4
Build Identifier: 

Currently ubuntu has svn snapshot r22592 and sometimes when starting thunar it opens two windows. Original report here.
https://launchpad.net/distros/ubuntu/+source/thunar/+bug/51150
Will package the latest svn next week or 0.4 if it's out by then.

Reproducible: Always
Comment 1 Benedikt Meurer editbugs 2006-08-31 22:24:59 CEST
I'm probably the one that saw more bugs and crashes in Thunar than anyone else, but this is really a funny, new one. ;-)

Tho, I'm pretty sure I know the answer... Well, atleast something that can turn into an answer later.

When Thunar starts it first sends a message to the org.xfce.Thunar service (w/o auto activation) and if the service responds, the new instance will be shut down. If the system is under heavy load it may however be possible that a service is running, but does not respond within time, and so the new instance will open the requested windows. BUT the service still receives the request after some time and so it'll also open a window. The timeout of the client is 2s, which "should" be more than enough. But, well, one can think of a special case where the D-Bus daemon is very busy or even the whole system is unresponsive (i.e. buggy driver, etc.).

If you are able to reproduce the problem, you can try to increase the timeouts in thunar-dbus-client.c (just replace all occurances of 2000 with a higher value) and try again.
Comment 2 Jani Monoses 2006-09-01 10:21:05 CEST
I cannot reproduce it even when doing heavy disk IO in the background. It happened 2 or 3 times so far and it all seemed to be right after session startup.
If I _lowered_ the timeouts to 20 from 2000 it did not occur either.
Comment 3 Benedikt Meurer editbugs 2006-09-03 16:42:03 CEST
Moving to 0.5.0rc2.
Comment 4 Olivier Fourdan editbugs 2006-09-08 08:59:54 CEST
I'm seeing the same with Terminal. When the system is loaded, opening Terminal once ends up with sometimes 2 or even 3 terminals opened.
Comment 5 Benedikt Meurer editbugs 2006-09-08 09:09:02 CEST
That sounds indeed like a D-Bus timeout problem then.
Comment 6 Benedikt Meurer editbugs 2006-09-13 15:59:49 CEST
Does it work if you set the timeout to -1?
Comment 7 Jani Monoses 2006-09-13 17:08:23 CEST
seems to work with thunar. At first it seemed to have hanged at launch (>5 sec)
but then on subsequent launches (after kill) it works fine, so it may have been an accident
Comment 8 Benedikt Meurer editbugs 2006-09-13 17:09:41 CEST
-1 is "dbus default timeout", I haven't figured out what that means exactly, but it looks like its the preferred value here.
Comment 9 Benedikt Meurer editbugs 2006-09-13 17:11:39 CEST
Fixed with revision 23143.

2006-09-13	Benedikt Meurer <benny@xfce.org>

	* thunar/thunar-dbus-client.c: Use default dbus connection timeout.
	  Bug #2243.

Bug #2243

Reported by:
Jani Monoses
Reported on: 2006-08-31
Last modified on: 2009-07-17

People

Assignee:
Jannis Pohlmann
CC List:
1 user

Version

Version:
0.3.3svn

Attachments

Additional information