! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
xfwm4: ./configure silently disables composite if libs are missing
Status:
RESOLVED: FIXED

Comments

Description Johan Sandelin 2006-08-16 17:07:08 CEST
Overview Description:
When running the ./configure script and libs needed for compiling the built-in compositor, the compositor is silently disabled.

Steps to Reproduce:
1. Make sure that one or more of the following libs are not installed:
   xcomposite xfixes xrender xdamage
2. Check out SVN version of xfwm4
3. run ./autogen.sh

Actual Results:
Configure script finishes, informing the user that the built-in compositor is disabled.

Expected Results:
Configure script finishes, informing the user that the built-in compositor is disabled and why is was disabled.

Possible solution:
I'm sorry if this is a stupid suggestion - I haven't used autotools before. Is there a reason that stderr from pkg-config is derirected to /dev/null in configure.ac.in? If it was redirected to stdout instead, the user would be aware of why the compositor is disabled. The same applies for the detection of Xrender earlier in the configure script.
Comment 1 Johan Sandelin 2006-08-16 17:13:59 CEST
Created attachment 741 
Makes output of pkg-config be redirected to stdout instead of /dev/null during configure

This is my first patch ever, so please bear with me if it's total garbage. I executed "diff -u -t trunk/configure.ac.in.original trunk/configure.ac.in" in the xfwm4 directory, and added the above command to the first line in the patch. I had a look at some other patches, and they seemed to be done that way :)

Also, I have no idea if this is a good solution - it is merely a suggestion from a n00b :)
Comment 2 Olivier Fourdan editbugs 2006-08-17 17:54:28 CEST
The patch is now applied.
Thanks ;)

Bug #2178

Reported by:
Johan Sandelin
Reported on: 2006-08-16
Last modified on: 2009-07-14

People

Assignee:
Olivier Fourdan
CC List:
0 users

Version

Attachments

Additional information