2175 – Fix for double free on exit

Fix for double free on exit

Status:

CLOSED: FIXED

Priority:
Medium

Severity:
normal

Product:
Xfce4-verve-plugin

Component:

General

Comments

Description Jasper Huijsmans editbugs

2006-08-16 09:43:15 CEST

Copy the binaries GList for the g_completion, otherwise the original list can be clobbered when you free the merged list later. Patch follows.

Comment 1 Jasper Huijsmans editbugs

2006-08-16 09:47:02 CEST

Created attachment 738 
Fix double free verve_env_finalize

 * Fix double free: copy env->binaries instead of concatenating for g_completion.
 * Remove a few unused variables to pass -Wall -Werror
 * 'Fix' small C99-ism (declaring variables in the middle of a block.

Comment 2 Jannis Pohlmann editbugs

2006-08-16 19:45:17 CEST

Thanks for the report and patch, Jasper. I applied a slightly modified version in revision 1910:

2006-08-16      Jannis Pohlmann <jannis@xfce.org>

        * panel-plugin/verve-plugin.c, panel-plugin/verve-history.c,
          panel-plugin/verve.c, panel-plugin/verve-env.c: Apply patch
          from Jasper, which removes several unused variables, evil
          C99-style and avoids a double-free'd GList. Bug #2175.

Bug #2175

Reported by:
Jasper Huijsmans

Reported on: 2006-08-16
Last modified on: 2010-10-28

People

Assignee:
Florian Rivoal

CC List:
1 user

Version

Version:
0.3.6 or older

Target Milestone:
0.3.6 or older

Attachments

Fix double free verve_env_finalize (3.54 KB, patch)
2006-08-16 09:47 CEST , Jasper Huijsmans

no flags

Additional information