! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Anti-aliased rendering of the analogue clock face (libxfcegui4)
Status:
RESOLVED: FIXED
Severity:
enhancement
Product:
Xfce4-panel

Comments

Description Darren Salt 2006-07-04 17:37:12 CEST
The clock face would look better if rendered either larger (then shrunk for display) or rendered using anti-aliasing. Fortunately, Cairo is likely to be available and will do the latter...
Comment 1 Darren Salt 2006-07-04 17:40:20 CEST
Created attachment 644 
Render the clock face using Cairo

The rendering method is selected at build time; default is --enable-cairo.
Comment 2 Darren Salt 2006-07-04 18:41:29 CEST
Created attachment 645 
Render the clock face using Cairo

Revised version - requires GTK+2.8 without --disable-cairo.
Comment 3 Jasper Huijsmans editbugs 2006-07-11 10:58:40 CEST
Thanks for doing this! As far as I know we still only require gtk 2.6, so we can't depend on cairo at the moment. Maybe we could use #ifdef's (ugly!) or otherwise we'd have to wait until Xfce 4.6 (probably a long time) :(

Unfortunately I don't have much time to review the patch, but I'll try to have a look at it soon. 
Comment 4 Darren Salt 2006-07-11 17:17:35 CEST
Not a problem: #ifdefs etc. are in the patch.

"requires GTK+2.8 without --disable-cairo" is misleading. If libcairo is missing then the existing requirement of GTK+2.6 remains sufficient.
Comment 5 Darren Salt 2006-07-24 21:06:18 CEST
Created attachment 675 
Render the clock face using Cairo

Minor fix: use cairo_fill rather than cairo_stroke to render the ticks (when using rectangles).
Comment 6 Nick Schermer editbugs 2007-07-09 08:09:08 CEST
The clock in trunk uses cairo rendering. If you think you can improve it, feel free to send a patch, but this one can be closed.

(clock code is now inside the clock plugin in xfce4-panel)

Bug #1985

Reported by:
Darren Salt
Reported on: 2006-07-04
Last modified on: 2010-11-20

People

Assignee:
Nick Schermer
CC List:
0 users

Version

Version:
Unspecified

Attachments

Render the clock face using Cairo (11.38 KB, patch)
2006-07-04 17:40 CEST , Darren Salt
no flags
Render the clock face using Cairo (11.75 KB, patch)
2006-07-04 18:41 CEST , Darren Salt
no flags
Render the clock face using Cairo (11.08 KB, patch)
2006-07-24 21:06 CEST , Darren Salt
no flags

Additional information