User-Agent: Mozilla/5.0 (X11; U; Linux i686; de; rv:1.8.0.4) Gecko/20060508 Firefox/1.5.0.4 Build Identifier: Mozilla/5.0 (X11; U; Linux i686; de; rv:1.8.0.4) Gecko/20060508 Firefox/1.5.0.4 When compiling xfdesktop as usual, since the last two SVN commits I get the following error: make[2]: Entering directory `/misc/down/xfce4-goodies/xfce/xfdesktop/panel-plugin' /bin/sh ../libtool --tag=CC --mode=link gcc -Wall -O2 -pipe -march=athlon-xp -o xfce4-popup-menu xfce4_popup_menu-xfce4-popup-menu.o -lSM -lICE -lX11 -Wl,--export-dynamic -lgtk-x11-2.0 -lgdk-x11-2.0 -latk-1.0 -lgdk_pixbuf-2.0 -lm -lpangoxft-1.0 -lpangox-1.0 -lpango-1.0 -lgobject-2.0 -lgmodule-2.0 -ldl -lglib-2.0 gcc -Wall -O2 -pipe -march=athlon-xp -o xfce4-popup-menu xfce4_popup_menu-xfce4-popup-menu.o -Wl,--export-dynamic -lSM -lICE -lX11 /usr/lib/libgtk-x11-2.0.so /usr/lib/libgdk-x11-2.0.so /usr/lib/libatk-1.0.so /usr/lib/libgdk_pixbuf-2.0.so -lm /usr/lib/libpangoxft-1.0.so /usr/lib/libpangox-1.0.so /usr/lib/libpango-1.0.so /usr/lib/libgobject-2.0.so /usr/lib/libgmodule-2.0.so -ldl /usr/lib/libglib-2.0.so /usr/bin/ld: cannot find -lSM collect2: ld returned 1 exit status make[2]: *** [xfce4-popup-menu] Fehler 1 make[2]: Leaving directory `/misc/down/xfce4-goodies/xfce/xfdesktop/panel-plugin' make[1]: *** [all-recursive] Fehler 1 make[1]: Leaving directory `/misc/down/xfce4-goodies/xfce/xfdesktop' make: *** [all] Fehler 2 If I replace -lSM by /usr/X11R6/lib/libSM.so and so on, then it works. This happens on Debian Sarge. I guess, there is something is configure.ac missing, so that the linker search also in /usr/X11R6/lib for the libraries. Reproducible: Always Steps to Reproduce:
(added Olivier to CC, since it was his commit)
Benny's our autotools expert...
Can you try with revision 22272?
No change. The X11 includes are correct, but the -L/usr/X11R6/lib entry is missing in LIBADD. By the way, in the corresponding commit you modified modules/menu/Makefile.am, but the error I described above is in panel-plugin/Makefile.am. Or am I wrong?
heh! yes; indeed. My bad.
Things is... that everything looks fine in panel-plugin
Created attachment 646 Suggested fix This should do the trick.
Benny, can you elaborate on why that could fix it? I noticed that some modules use that syntax and others dont. Should we move all modules to that syntax?
The syntax doesn't fix this bug, but the missing $(LIBX11_LDFLAGS). The $(...) should be preferred over @...@, as $(...) is handled by make, while @...@ is blindly substituted by sed.
Benny's fix solves it. Thanks.
I was too fast. Benny's fix solves it, but the commit in r22274, hasn't the decisive line. $(LIBX11_LDFLAGS) \ in xfce4_popup_menu_LDADD is missing.
Now it is fixed and xfdesktop compiles fine on my system.
Pfewww... ;)