! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
edit menu button does not always work
Status:
RESOLVED: FIXED
Product:
Xfdesktop
Component:
General

Comments

Description Jani Monoses 2006-06-10 19:16:24 CEST
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.3) Gecko/20060523 Ubuntu/dapper Firefox/1.5.0.3
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.3) Gecko/20060523 Ubuntu/dapper Firefox/1.5.0.3

Both the edit menu button or the entry on the desktop menu plugin's right click menu fails to edit the menu.xml file if the default one is not user writable (in /etc for example)
This is because it always calls xfce4-menueditor with an argument. If the argument were dropped the menueditor would do as when called from the command line and write over to ~/.config. But if it is told to edit /etc/.. it just silently fails.

A check to see if (dmp->use_default_menu) and then call xfce4-menueditor w/o arguments in the panel plugin fixes it, however that code can be modified in many ways to achieve this effect so I am not attaching a patch.


Reproducible: Always
Comment 1 Brian J. Tarricone (not reading bugmail) 2006-07-11 23:00:59 CEST
Fixed, thanks.

Bug #1911

Reported by:
Jani Monoses
Reported on: 2006-06-10
Last modified on: 2009-07-14

People

Assignee:
Brian J. Tarricone (not reading bugmail)
CC List:
0 users

Version

Attachments

Additional information