! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Patch to fix libxfce4util so that it parses the entirety of the desktop file
Status:
CLOSED: WONTFIX
Product:
Libxfce4util
Component:
General

Comments

Description Olivier Fourdan editbugs 2006-06-05 12:09:38 CEST
Following my own ML message, the attached patch makes libxfce4util desktop entry parsing behaves as described:

- If an key is set in the [Desktop Entry] section, then prefer/use the value from there
- If an entry is set out of the [Desktop Entry] section, then use that value as a fallback.

GNOME menu seems to do something similar.
Comment 1 Olivier Fourdan editbugs 2006-06-05 12:10:18 CEST
Created attachment 592 
The patch mentionned above.
Comment 2 Benedikt Meurer editbugs 2006-06-06 10:53:42 CEST
Hm, that doesn't seem right. The menu should only care for [Desktop Entry], the [Desktop Action...]s are only for the file manager, IMHO. Isn't there a category for screensavers that can be ignored in xfdesktop?
Comment 3 Olivier Fourdan editbugs 2006-06-06 19:19:20 CEST
Well, it works. From the desktop files, there is no "screensaver" category.
Comment 4 Olivier Fourdan editbugs 2006-06-14 10:40:08 CEST
Created attachment 603 
Example of a desktop file that shouldn't show

Benny, I fail to undertand what could be the meaning of "NoDisplay=true" in a desktop action... I attach an example of an offending file as an example.

So the change in the parsing in the patch provided will simply make options such as "NoDisplay=true" visible, that wouldn't override any option set in the "Desktop entry".

I think we should fix that, one way or another. And I fail to see another way, but by supporting the "directory" option (and we currently don't).
Comment 5 Benedikt Meurer editbugs 2006-06-14 17:59:15 CEST
Dunno... I'm still pretty sure that this should not be addressed at the .desktop parser level, but is the job of the menu implementation. Maybe for 4.4 xfdesktop could simply blacklist several well known .desktop files (like the KDE screensavers)? Xfce 4.6 will hopefully include a more standard compliant menu implementation that will be able to handle this.
Comment 6 Olivier Fourdan editbugs 2006-06-14 19:46:57 CEST
Anyway it needs to be fixed.
Comment 7 Olivier Fourdan editbugs 2006-06-16 12:10:39 CEST
Ok, I've implemented it in the module menu instead, I'll post a bug and a patch to Brian...

Bug #1894

Reported by:
Olivier Fourdan
Reported on: 2006-06-05
Last modified on: 2009-07-14

People

Assignee:
Xfce Bug Triage
CC List:
0 users

Version

Attachments

The patch mentionned above. (1.26 KB, patch)
2006-06-05 12:10 CEST , Olivier Fourdan
no flags
Example of a desktop file that shouldn't show (6.41 KB, text/plain)
2006-06-14 10:40 CEST , Olivier Fourdan
no flags

Additional information