User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.3) Gecko/20060503 Firefox/1.5.0.3 (Swiftfox) Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.3) Gecko/20060503 Firefox/1.5.0.3 (Swiftfox) The current file choose could hang the system, the one used in the Thunar uca editor is much better and Benny probably wouldn't mind if we use it here ^_~. Reproducible: Always Steps to Reproduce: 1. Can use 100% cpu if file not found
Created attachment 588 file chooser from thunar for keyboard plugin
Um, XfceFileChooser is just a wrapper around GtkFileChooser. In other words, they're the same thing. Not saying it shouldn't be changed, since XfceFileChooser is deprecated, but I'm not sure why you're saying this is "from thunar".
The code is copied from thunar, because it has a better way of checking (if the file exists). So that's why it's from thunar... And i know the old code is a wrapper, but who cares? If gtk can provide what we need, why to use a wrapper? Anyway this patches fixes the issue and makes the dialog a bit better for finding executables.
thanks for the patch committed with revision 21949
In the good old days, it was not uncommon that patches were required to use the same source indenting scheme as the patched code, to keep readability and the code homogeneous. I admit that I liked that time...
i changed the indentation style, i must admit i forgot (many things in my mind these days)
Sorry for the indenting, i was a bit in a hurry, so i never though about it.