! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Thunar fails to build on Sun Studio Pro
Status:
CLOSED: FIXED
Priority:
Very High
Severity:
blocker
Product:
Thunar-vfs
Component:
General

Comments

Description Leo Zhadanovsky 2006-05-25 20:13:25 CEST
cc -DHAVE_CONFIG_H -I. -I. -I.. -I.. -DEXO_API_SUBJECT_TO_CHANGE -DEXO_DISABLE_DEPRECATED -DG_LOG_DOMAIN=\"thunar-vfs\" -DLIBEXECDIR=\"/usr/local/libexec\" -DSN_API_NOT_YET_FROZEN -DTHUNAR_VFS_COMPILATION -DTHUNAR_VFS_VERSION_API=\"1\" -DG_DISABLE_CAST_CHECKS -I/usr/local/include -I/usr/local/include/exo-0.3 -I/usr/local/include/gtk-2.0 -I/usr/local/include/xfce4 -I/usr/local/lib/gtk-2.0/include -I/usr/local/include/atk-1.0 -I/usr/local/include/cairo -I/usr/local/include/pango-1.0 -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -mt -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include/fam -I/usr/local/include/libpng12 -I/usr/local/include/startup-notification-1.0 -g -c thunar-vfs-info.c  -KPIC -DPIC -o .libs/libthunar_vfs_1_la-thunar-vfs-info.o
"/usr/local/include/xfce4/libxfce4util/libxfce4util-config.h", line 31: warning: syntax error:  empty declaration
"/usr/local/include/xfce4/libxfce4util/libxfce4util-config.h", line 45: warning: syntax error:  empty declaration
"/usr/local/include/xfce4/libxfce4util/xfce-generics.h", line 31: warning: syntax error:  empty declaration
"/usr/local/include/xfce4/libxfce4util/xfce-generics.h", line 96: warning: syntax error:  empty declaration
"/usr/local/include/xfce4/libxfce4util/xfce-kiosk.h", line 31: warning: syntax error:  empty declaration
"/usr/local/include/xfce4/libxfce4util/xfce-kiosk.h", line 43: warning: syntax error:  empty declaration
"/usr/local/include/exo-0.3/exo/exo-config.h", line 32: warning: syntax error:  empty declaration
"/usr/local/include/exo-0.3/exo/exo-config.h", line 76: warning: syntax error:  empty declaration
"/usr/local/include/exo-0.3/exo/exo-binding.h", line 33: warning: syntax error:  empty declaration
"/usr/local/include/exo-0.3/exo/exo-binding.h", line 111: warning: syntax error:  empty declaration
"/usr/local/include/exo-0.3/exo/exo-cell-renderer-ellipsized-text.h", line 32: warning: syntax error:  empty declaration
"/usr/local/include/exo-0.3/exo/exo-cell-renderer-ellipsized-text.h", line 61: warning: syntax error:  empty declaration
"/usr/local/include/exo-0.3/exo/exo-pango-extensions.h", line 33: warning: syntax error:  empty declaration
"/usr/local/include/exo-0.3/exo/exo-pango-extensions.h", line 48: warning: syntax error:  empty declaration
"/usr/local/include/exo-0.3/exo/exo-ellipsized-label.h", line 34: warning: syntax error:  empty declaration
"/usr/local/include/exo-0.3/exo/exo-ellipsized-label.h", line 68: warning: syntax error:  empty declaration
"/usr/local/include/exo-0.3/exo/exo-execute.h", line 30: warning: syntax error:  empty declaration
"/usr/local/include/exo-0.3/exo/exo-execute.h", line 54: warning: syntax error:  empty declaration
"/usr/local/include/exo-0.3/exo/exo-gdk-pixbuf-extensions.h", line 32: warning: syntax error:  empty declaration
"/usr/local/include/exo-0.3/exo/exo-gdk-pixbuf-extensions.h", line 50: warning: syntax error:  empty declaration
"/usr/local/include/exo-0.3/exo/exo-gtk-extensions.h", line 32: warning: syntax error:  empty declaration
"/usr/local/include/exo-0.3/exo/exo-gtk-extensions.h", line 41: warning: syntax error:  empty declaration
"/usr/local/include/exo-0.3/exo/exo-gobject-extensions.h", line 32: warning: syntax error:  empty declaration
"/usr/local/include/exo-0.3/exo/exo-gobject-extensions.h", line 37: warning: syntax error:  empty declaration
"/usr/local/include/exo-0.3/exo/exo-icon-bar.h", line 32: warning: syntax error:  empty declaration
"/usr/local/include/exo-0.3/exo/exo-icon-bar.h", line 99: warning: syntax error:  empty declaration
"/usr/local/include/exo-0.3/exo/exo-icon-view.h", line 33: warning: syntax error:  empty declaration
"/usr/local/include/exo-0.3/exo/exo-icon-view.h", line 344: warning: syntax error:  empty declaration
"/usr/local/include/exo-0.3/exo/exo-md5.h", line 34: warning: syntax error:  empty declaration
"/usr/local/include/exo-0.3/exo/exo-md5.h", line 59: warning: syntax error:  empty declaration
"/usr/local/include/exo-0.3/exo/exo-string.h", line 32: warning: syntax error:  empty declaration
"/usr/local/include/exo-0.3/exo/exo-string.h", line 55: warning: syntax error:  empty declaration
"/usr/local/include/exo-0.3/exo/exo-toolbars-model.h", line 33: warning: syntax error:  empty declaration
"/usr/local/include/exo-0.3/exo/exo-toolbars-model.h", line 183: warning: syntax error:  empty declaration
"/usr/local/include/exo-0.3/exo/exo-toolbars-view.h", line 33: warning: syntax error:  empty declaration
"/usr/local/include/exo-0.3/exo/exo-toolbars-view.h", line 87: warning: syntax error:  empty declaration
"/usr/local/include/exo-0.3/exo/exo-toolbars-editor.h", line 33: warning: syntax error:  empty declaration
"/usr/local/include/exo-0.3/exo/exo-toolbars-editor.h", line 78: warning: syntax error:  empty declaration
"/usr/local/include/exo-0.3/exo/exo-toolbars-editor-dialog.h", line 33: warning: syntax error:  empty declaration
"/usr/local/include/exo-0.3/exo/exo-toolbars-editor-dialog.h", line 68: warning: syntax error:  empty declaration
"/usr/local/include/exo-0.3/exo/exo-tree-view.h", line 30: warning: syntax error:  empty declaration
"/usr/local/include/exo-0.3/exo/exo-tree-view.h", line 80: warning: syntax error:  empty declaration
"/usr/local/include/exo-0.3/exo/exo-url.h", line 30: warning: syntax error:  empty declaration
"/usr/local/include/exo-0.3/exo/exo-url.h", line 60: warning: syntax error:  empty declaration
"/usr/local/include/exo-0.3/exo/exo-utils.h", line 30: warning: syntax error:  empty declaration
"/usr/local/include/exo-0.3/exo/exo-utils.h", line 84: warning: syntax error:  empty declaration
"/usr/local/include/exo-0.3/exo/exo-wrap-table.h", line 31: warning: syntax error:  empty declaration
"/usr/local/include/exo-0.3/exo/exo-wrap-table.h", line 79: warning: syntax error:  empty declaration
"/usr/local/include/exo-0.3/exo/exo-xsession-client.h", line 32: warning: syntax error:  empty declaration
"/usr/local/include/exo-0.3/exo/exo-xsession-client.h", line 79: warning: syntax error:  empty declaration
"../thunar-vfs/thunar-vfs-config.h", line 30: warning: syntax error:  empty declaration
"../thunar-vfs/thunar-vfs-config.h", line 61: warning: syntax error:  empty declaration
"../thunar-vfs/thunar-vfs-mime-info.h", line 26: warning: syntax error:  empty declaration
"../thunar-vfs/thunar-vfs-mime-info.h", line 118: warning: syntax error:  empty declaration
"../thunar-vfs/thunar-vfs-path.h", line 30: warning: syntax error:  empty declaration
"../thunar-vfs/thunar-vfs-path.h", line 265: warning: syntax error:  empty declaration
"../thunar-vfs/thunar-vfs-types.h", line 29: warning: syntax error:  empty declaration
"../thunar-vfs/thunar-vfs-types.h", line 150: warning: syntax error:  empty declaration
"../thunar-vfs/thunar-vfs-info.h", line 32: warning: syntax error:  empty declaration
"../thunar-vfs/thunar-vfs-info.h", line 187: warning: syntax error:  empty declaration
"../thunar-vfs/thunar-vfs-exec.h", line 26: warning: syntax error:  empty declaration
"../thunar-vfs/thunar-vfs-exec.h", line 50: warning: syntax error:  empty declaration
"../thunar-vfs/thunar-vfs-mime-handler.h", line 30: warning: syntax error:  empty declaration
"../thunar-vfs/thunar-vfs-mime-handler.h", line 78: warning: syntax error:  empty declaration
"../thunar-vfs/thunar-vfs-mime-application.h", line 31: warning: syntax error:  empty declaration
"../thunar-vfs/thunar-vfs-mime-application.h", line 87: warning: syntax error:  empty declaration
"../thunar-vfs/thunar-vfs-mime-database.h", line 27: warning: syntax error:  empty declaration
"../thunar-vfs/thunar-vfs-mime-database.h", line 71: warning: syntax error:  empty declaration
"thunar-vfs-info.c", line 240: prototype mismatch: 2 args passed, 4 expected
"thunar-vfs-info.c", line 244: improper member use: f_bavail
Comment 1 Benedikt Meurer editbugs 2006-06-06 12:17:20 CEST
Doesn't the Sun Studio compiler define the __sun__ preprocessor symbol?
Comment 2 Leo Zhadanovsky 2006-06-07 22:45:42 CEST
(In reply to comment #1)
> Doesn't the Sun Studio compiler define the __sun__ preprocessor symbol?
> 

I suppose not.
Comment 3 Benedikt Meurer editbugs 2006-06-07 22:46:34 CEST
What does the Sun Studio compiler use to identify the platform?
Comment 4 Leo Zhadanovsky 2006-06-07 22:48:44 CEST
(In reply to comment #3)
> What does the Sun Studio compiler use to identify the platform?
> 

Where would I look this up?
Comment 5 Benedikt Meurer editbugs 2006-06-07 22:50:03 CEST
Compiler docs, or maybe sample projects. Just a wild guess: Does the compiler define any of "sun", "sun__" or "__sun"?
Comment 6 Benedikt Meurer editbugs 2006-07-08 13:21:51 CEST
Any news?
Comment 7 Benedikt Meurer editbugs 2006-07-09 21:23:32 CEST
Moving to 0.4.0rc1.
Comment 8 Benedikt Meurer editbugs 2006-07-27 15:41:32 CEST
Resolving to WONTFIX due to missing infos.
Comment 9 Leo Zhadanovsky 2006-08-29 22:53:51 CEST
(In reply to comment #8)
> Resolving to WONTFIX due to missing infos.
> 

I found some posting that says that someone else who write codes with this symbol has to do the following:

#if defined(__SVR4) && defined(__sun) && defined(__SUNPRO_CC)
#  if defined(__SunOS_5_0) || defined(__SunOS_5_1) ||       defined(__SunOS_5_2) || defined(__SunOS_5_3) ||       defined(__SunOS_5_4) || defined(__SunOS_5_5) ||       defined(__SunOS_5_6) || defined(__SunOS_5_7) ||       defined(__SunOS_5_8) || defined(__SunOS_5_9) ||       defined(__SunOS_5_10)

http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6448611

Does this give any hints?
Comment 10 Benedikt Meurer editbugs 2006-08-29 22:59:09 CEST
Hm, __sun looks like it should work. grep for __sun__ in the thunar-vfs directory, which should bring up a list of preprocessor statements (in different places, depending on the Thunar version you are trying to build, it'd of course be preferred if you could try with the latest SVN snapshot, so we can apply your patch instantely for the upcoming rc1).

For each defined(__sun__), replace it with (defined(__sun__) || defined(__sun)) and try to compile it.
Comment 11 Leo Zhadanovsky 2006-08-29 23:25:57 CEST
(In reply to comment #10)
> Hm, __sun looks like it should work. grep for __sun__ in the thunar-vfs
> directory, which should bring up a list of preprocessor statements (in
> different places, depending on the Thunar version you are trying to build, it'd
> of course be preferred if you could try with the latest SVN snapshot, so we can
> apply your patch instantely for the upcoming rc1).
> 
> For each defined(__sun__), replace it with (defined(__sun__) || defined(__sun))
> and try to compile it.
> 

That seems to have worked, but now I get

"thunar-shortcuts-view.c", line 706: void function cannot return value

I will fix this and let you know what happens.
Comment 12 Leo Zhadanovsky 2006-08-30 02:52:08 CEST
(In reply to comment #11)
> (In reply to comment #10)
> > Hm, __sun looks like it should work. grep for __sun__ in the thunar-vfs
> > directory, which should bring up a list of preprocessor statements (in
> > different places, depending on the Thunar version you are trying to build, it'd
> > of course be preferred if you could try with the latest SVN snapshot, so we can
> > apply your patch instantely for the upcoming rc1).
> > 
> > For each defined(__sun__), replace it with (defined(__sun__) || defined(__sun))
> > and try to compile it.
> > 
> 
> That seems to have worked, but now I get
> 
> "thunar-shortcuts-view.c", line 706: void function cannot return value
> 
> I will fix this and let you know what happens.
> 


The next problem I have come across is this:

cc -g -o .libs/thunar-sendto-email thunar_sendto_email-main.o  -L/usr/local/lib -L/opt/SUNWspro/lib ../../thunar-vfs/.libs/libthunar-vfs-1.so -lCstd -lCrun -lc -L/usr/openwin/lib -lgthread-2.0 -lrt -lstartup-notification-1 -lexo-0.3 -lgtk-x11-2.0 -lxfce4util -lgdk-x11-2.0 -latk-1.0 -lgdk_pixbuf-2.0 -lpangocairo-1.0 -lpango-1.0 /usr/local/lib/libcairo.so /usr/local/lib/libfreetype.so -lfontconfig -lpng12 -lz -lXrender -lSM -lICE -lX11 -lsocket -lnsl -lm -lgobject-2.0 -lgmodule-2.0 -ldl -lglib-2.0 -lintl -liconv -R/usr/local/lib -R/opt/SUNWspro/lib
Undefined                       first referenced
 symbol                             in file
mkdtemp                             thunar_sendto_email-main.o
ld: fatal: Symbol referencing errors. No output written to .libs/thunar-sendto-email
make[3]: *** [thunar-sendto-email] Error 1
make[3]: Leaving directory `/usr/local/src/rpm-packages/BUILD/Thunar-0.3.2beta2/plugins/thunar-sendto-email'

This is because Solaris lacks an mkdtemp function, I believe.
Comment 13 Benedikt Meurer editbugs 2006-08-30 07:32:01 CEST
That's already fixed in the latest SVN builds. Search bugzilla for mkdtemp to find the patch.
Comment 14 Leo Zhadanovsky 2006-08-30 08:34:23 CEST
Created attachment 759 
Sun Studio 11 Thunar Patch
Comment 15 Leo Zhadanovsky 2006-08-30 08:35:07 CEST
(In reply to comment #14)
> Created an attachment (id=759) [edit]
> Sun Studio 11 Thunar Patch
> 

Ok, that's my complete patch that I had to apply to make Thunar compile on Sun Studio 11, just for your reference.
Comment 16 Benedikt Meurer editbugs 2006-08-30 10:17:59 CEST
Committed with revision 22946.

2006-08-30	Benedikt Meurer <benny@xfce.org>

	* thunar-vfs/thunar-vfs-io-local.c, thunar-vfs/thunar-vfs-os-generic.c,
	  thunar/thunar-shortcuts-view.c(thunar_shortcuts_view_drag_leave),
	  thunar/thunar-tree-view.c(thunar_tree_view_drag_leave): Enable
	  compilation with Sun Studio Pro. Bug #1852.

Bug #1852

Reported by:
Leo Zhadanovsky
Reported on: 2006-05-25
Last modified on: 2010-11-07

People

Assignee:
Jannis Pohlmann
CC List:
2 users

Version

Version:
unspecified

Attachments

Sun Studio 11 Thunar Patch (4.09 KB, patch)
2006-08-30 08:34 CEST , Leo Zhadanovsky
no flags

Additional information