! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
runtime warnings after moving media icons
Status:
RESOLVED: FIXED
Product:
Xfdesktop
Component:
General

Comments

Description Jani Monoses 2006-05-23 18:11:01 CEST
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.3) Gecko/20060513 Ubuntu/dapper Firefox/1.5.0.3
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.3) Gecko/20060513 Ubuntu/dapper Firefox/1.5.0.3

If I move a media icon on the desktop then press F5 I get this. Moving regular file icons does not produce this even if there is a media icon on the desktop.

(xfdesktop:17431): thunar-vfs-WARNING **: Attempt detected to finalize the ThunarVfsVolumeManager, while there are still ThunarVfsVolume instances with a reference count of 2 or more. This usually presents a bug in the application.


Reproducible: Always
Comment 1 Brian J. Tarricone (not reading bugmail) 2006-05-25 07:34:53 CEST
Ok, this was annoying to track donw.  The problem here is that, when you move an icon, it doesn't write out the icon positions to disk for another 7 seconds, so it can batch them if you move multiple icons quickly.  However, when you move it, it g_object_ref()s the icon (and unrefs after it actually saves the position), which causes it to not get destroyed when the F5 refresh removes it from the icon view.  Since the icon still exists, it still holds a reference to its ThunarVfsVolume, which doesn't get destroyed.  Then we drop our last reference to the ThunarVfsVolumeManager, and it prints out the warning.  Note if you move an icon, then wait about 10 seconds, then hit F5, thunar-vfs doesn't print the warning.  So... I think the right thing to do here is to flush the icon positions to disk before we refresh.  That'll fix that bug, and also make sure the icons are repositioned correctly after the refresh.

Anyway, bottom line: this is fixed now ^_^

Bug #1843

Reported by:
Jani Monoses
Reported on: 2006-05-23
Last modified on: 2009-07-14

People

Assignee:
Brian J. Tarricone (not reading bugmail)
CC List:
0 users

Version

Attachments

Additional information