! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
loop when minimizing krusader to tray
Status:
RESOLVED: FIXED
Product:
Xfce4-panel
Component:
Notification Area

Comments

Description pholie 2006-05-22 17:29:04 CEST
User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; X11; Linux i686; en) Opera 9.00
Build Identifier: xfce-svn pre 4.4

I have krusader (file manager) set so that when I minimize it, it hides into tray. In xfce when I minimize it and restore it from time by clicking on its tray icon a few times, it ends in a loop. I can see it going into and out of tray. Sometimes I see the tray icon in its own little window somewhere on the screen (not in tray).

Reproducible: Always

Actual Results:  
it sucks


nothing
Comment 1 Olivier Fourdan editbugs 2006-05-22 20:24:20 CEST
Seems krusader has not been ported to the EWMH systray protocol like the rest of KDE apps.

This protocols is not supported by default in xfce 4.4 (xfwm4 4.2.X used to act as a proxy between the KDE systray and the standard EWMH systray protocol, but since KDE now supports the standard, this options is deprecated in xfwm4 4.4).

You can work around the problem by either:

- Unset the option minimize to systray in Krusader (systray are not made for that anyway IMHO)
- recompile xfwm4 with ENABLE_KDE_SYSTRAY_PROXY=1 set
  E.g.
  CFLAGS="$CFLAGS -DENABLE_KDE_SYSTRAY_PROXY=1" ./configure --prefix=blah blah

I've add a configure option in svn for that now, but there is no chance for this option to be enabled by default.

Please note that the proxy in xfwm4 will fix the issue with the window reappearing, but that won't help with showing krusader icon in the standard system tray as it requires some hacks that have been definitely removed from our systray... In other words, you'll be able to hide krusader window, but no icon will show in systray (well, something will show, like a 1 pix line, but that's useless).
Comment 2 Olivier Fourdan editbugs 2006-05-23 09:18:15 CEST
Humm, I guess it's a bug in our systray...

In libxfcegui4/xfce_systemtray.c, in function xfce_system_tray_dock_request (), removing the return in if g_hash_table_lookup () finds the notification fixes the issue.

So I think it's rather a removal that is not done properly, because on first systray request, it works. After a removal, it doesn't work anymore.

Comment 3 Olivier Fourdan editbugs 2006-05-23 21:09:42 CEST
A bit more investigations shows that 1) GNOME has the same issue (although with less iterations, prolly because of different timings) and 2) we never get the unplug message from the gtk_plug.

So either KDE is doing something totally non standard that confuses gtk_plug or there is a bug in gtk_plug. Or something else I miss.
Comment 4 Olivier Fourdan editbugs 2006-05-23 22:02:46 CEST
Ok, I've committed a fix to libxfcegui4 that seems to work fine with krusader. Dunno if that's much in line with the standard (that particular part doesn't seem to be much covered by the standard though).

Please update to libxfcegui4-4.3.90.x rev. 21804 from svn or above, and test. Works for me at least.
Comment 5 pholie 2006-05-24 09:29:56 CEST
Yes, it works for me now too.

Bug #1836

Reported by:
pholie
Reported on: 2006-05-22
Last modified on: 2010-11-20

People

Assignee:
Nick Schermer
CC List:
0 users

Version

Version:
Unspecified

Attachments

Additional information