! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Launcher menu not updated while working in the preferences dialog
Status:
RESOLVED: FIXED
Product:
Xfce4-panel

Comments

Description Nick Schermer editbugs 2006-05-21 19:12:47 CEST
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.3) Gecko/20060503 Firefox/1.5.0.3 (Swiftfox)
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.3) Gecko/20060503 Firefox/1.5.0.3 (Swiftfox)

When you change items in the laucher pref. dialog, no new menu is regerated. Not IMHO but it could lead into a seg fault.

Reproducible: Always

Steps to Reproduce:
1. Create launcher with 1 item (no arrow button)
2. Open pref dialog and add 1 new item
3. The arrow button is shown
4. Click the arrow button
5. Crash

Actual Results:  
Panel crash because there is no menu generated (yet) because perf. dialog was still open.

Expected Results:  
2 Options:

1. Don't display the arrow button till the menu is generated
2. Update the menu when a change is made in the pref dialog
Comment 1 Jasper Huijsmans editbugs 2006-05-21 19:19:48 CEST
Oh, that's an ugly one. I tried optimizing a bit by not generating the menu until the dialog closes, but I really do want to give the feedback of showing/hiding the button... 
Comment 2 Jasper Huijsmans editbugs 2006-05-21 19:38:10 CEST
Rev. 21760 should at least not crash anymore, but I still want to look for a better solution, so I'm leaving the report open.
Comment 3 Jasper Huijsmans editbugs 2006-08-13 09:17:07 CEST
Ok, I haven't thought of a better fix, so I'm leaving it as it is now.

Bug #1832

Reported by:
Nick Schermer
Reported on: 2006-05-21
Last modified on: 2010-11-20

People

Assignee:
Nick Schermer
CC List:
0 users

Version

Version:
Unspecified

Attachments

Additional information