! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
context menu of unmountd volume icons
Status:
RESOLVED: FIXED
Product:
Xfdesktop
Component:
General

Comments

Description Jani Monoses 2006-05-11 19:01:39 CEST
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.1) Gecko/20060413 Ubuntu/dapper Firefox/1.5.0.1
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.1) Gecko/20060413 Ubuntu/dapper Firefox/1.5.0.1

the patch at 1763 tried to handle the context menu when the icon is unmounted
so it does not show separators as the first item or 'open terminal here' when there is an info leftover but the volume is unmounted and the path may be invalid
these changes are not present in svn 

http://bugzilla.xfce.org/show_bug.cgi?id=1763

Reproducible: Always
Comment 1 Brian J. Tarricone (not reading bugmail) 2006-05-11 20:50:03 CEST
Sorry, I'm not really understanding what the problem is.  Could you clarify?  Maybe with a screenshot?
Comment 2 Jani Monoses 2006-05-12 06:34:46 CEST
this too appears only when the mountpoint directory is created on mount.
When the icon appears on the screen, there is not VfsInfo attached to it, and the volume is not mounted either. So the first addition in the menu is the separator at line 2162 in src/xfdesktop-file-icon-manager.c since all tests before fail and do not add any entry

The other issue is after the volume is unmounted, the VfsInfo is still there, so the entire context menu is shown even though since the mountpoint directory is removed some of the entries don't work- those added by UCA plugins which act on an existing directory, and properties while it works it does not have much info as it says free space:unknown, iow it is the properties of a nonexisting dir versus that of the volume.
Comment 3 Jani Monoses 2006-05-12 06:35:31 CEST
Created attachment 545 
context menu screenshot

here's what it looks like at start, on an unmounted but plugged in usb stick
Comment 4 Jani Monoses 2006-05-21 07:05:52 CEST
Created attachment 559 
fix 

this makes the custom actions entry not appear for unmounted volumes, and the separator only appear if entries were added before 'Mount'.
Comment 5 Brian J. Tarricone (not reading bugmail) 2006-05-23 09:15:10 CEST
Well, that patch leaves out a separator under other conditions, so I just redid how the separators are done entirely, so I think it should work ok now.

Bug #1799

Reported by:
Jani Monoses
Reported on: 2006-05-11
Last modified on: 2009-07-14

People

Assignee:
Brian J. Tarricone (not reading bugmail)
CC List:
0 users

Version

Attachments

context menu screenshot (9.03 KB, image/jpeg)
2006-05-12 06:35 CEST , Jani Monoses
no flags
fix (1.15 KB, patch)
2006-05-21 07:05 CEST , Jani Monoses
no flags

Additional information