! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Workspace names not saved when not changed by Workspaces MCS plugin
Status:
RESOLVED: WONTFIX

Comments

Description Stefan Stuhr 2006-05-07 23:59:20 CEST
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; da; rv:1.8.0.3) Gecko/20060426 Firefox/1.5.0.3
Build Identifier: 

When I change the name of a workspace (by using the PyXfce version of netk_workspace_change_name), it aren't saved between sessions. In fact, the Workspaces MCS plugin doesn't seem to register the change at all.

A simple restart of xfce-mcs-manager, and all workspace name changes not made in the Workspaces MCS dialog are lost.

I know that the name changes does work, as they shows up in the Xfdesktop middle click window list menu.

Reproducible: Always

Steps to Reproduce:
Comment 1 Olivier Fourdan editbugs 2006-05-08 07:49:22 CEST
I'm not surprise of that, I do not believe the workspace MCS plugin should be monitoring all changes to the WS names property and save channel accordingly. It's not designed for that.

Of you want to change workspace names, you should remove the workspace plugin and use your own that sets names by itself.
Comment 2 Stefan Stuhr 2006-05-12 23:48:58 CEST
(In reply to comment #1)
> I'm not surprise of that, I do not believe the workspace MCS plugin should be
> monitoring all changes to the WS names property and save channel accordingly.
> It's not designed for that.
> 
> Of you want to change workspace names, you should remove the workspace plugin
> and use your own that sets names by itself.

If this is a design decision, fine. Though it would be easier to provide integration in Xfce (i.e. renaming of workspaces from panel workspace switcher). But right now, the Workspaces MCS dialog can't even be used to rename workspaces. Instead, it causes xfce-mcs-manager to crash. Bug #1784.
Comment 3 Olivier Fourdan editbugs 2006-05-13 08:38:06 CEST
Yes it's a design decision. 

What don't you simply call the workspace plugin from your workspace switcher? 

The MCS goal was to have a centralized setting manager, not to allow any program to change any setting and save them all on its behalf.
Comment 4 Stefan Stuhr 2006-05-13 09:01:26 CEST
(In reply to comment #3)
> What don't you simply call the workspace plugin from your workspace switcher? 

I did that until I wanted to add support for setting per-button colors. I then wanted to have per-workspace preference dialogs for setting such things.
I am now considering to remove the per-button color settings, as things are getting too complex. Then I may as well go back to just launch xfce-setting-show workspaces.
Comment 5 Stefan Stuhr 2006-06-24 23:46:33 CEST
So, is this a WONTFIX? I am fine with that :)
Comment 6 Olivier Fourdan editbugs 2006-06-25 08:07:12 CEST
Well, it could be a wontfix because what you ask doesn't fit with the general design.

But it could be done, it's just like I don't plan it for now. So it's either a wontfix or later. Dunno. If you can live without, then I4d vote for a wontifx ;)
Comment 7 Olivier Fourdan editbugs 2006-10-12 22:03:23 CEST
Ok, wontfix then

Bug #1785

Reported by:
Stefan Stuhr
Reported on: 2006-05-07
Last modified on: 2009-07-14

People

Assignee:
Olivier Fourdan
CC List:
0 users

Version

Attachments

Additional information