User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.2) Gecko/20060414 Firefox/1.5.0.2 Build Identifier: Xfce SVN System: Arch Linux, built with autogen --prefix=/usr --sysconfdir=/etc; make; make install; GTK+ version = 2.8.17 GDB Trace: #0 0x08067b0f in xfdesktop_file_icon_manager_add_icon (fmanager=0x80c9370, info=0x0, volume=<value optimized out>, defer_if_missing=0) at xfdesktop-file-icon-manager.c:2346 #1 0x08067d52 in xfdesktop_file_icon_manager_add_removable_volume ( fmanager=0x80c9370, volume=0x80a3718) at xfdesktop-file-icon-manager.c:2668 #2 0x08067dc7 in xfdesktop_file_icon_manager_load_removable_media ( fmanager=0x80c9370) at xfdesktop-file-icon-manager.c:2736 #3 0x08068357 in xfdesktop_file_icon_manager_real_init (manager=0x80d2ab0, icon_view=0x80ca8d8) at xfdesktop-file-icon-manager.c:2857 #4 0x0805f8a2 in xfdesktop_icon_view_realize (widget=0x80ca8d8) at xfdesktop-icon-view.c:1062 #5 0xb7746fdb in g_cclosure_marshal_VOID__VOID () from /usr/lib/libgobject-2.0.so.0 #6 0xb7739ce9 in g_type_class_meta_marshal () from /usr/lib/libgobject-2.0.so.0 #7 0xb773a3a9 in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0 #8 0xb774a4eb in signal_emit_unlocked_R () from /usr/lib/libgobject-2.0.so.0 #9 0xb774ba20 in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0 #10 0xb774bd89 in g_signal_emit () from /usr/lib/libgobject-2.0.so.0 #11 0xb7ae41a4 in gtk_widget_realize () from /usr/lib/libgtk-x11-2.0.so.0 #12 0xb7ae48e5 in gtk_widget_set_parent () from /usr/lib/libgtk-x11-2.0.so.0 #13 0xb791bb61 in gtk_bin_add () from /usr/lib/libgtk-x11-2.0.so.0 #14 0xb7747adb in g_cclosure_marshal_VOID__OBJECT () from /usr/lib/libgobject-2.0.so.0 #15 0xb7739ce9 in g_type_class_meta_marshal () from /usr/lib/libgobject-2.0.so.0 #16 0xb773a3a9 in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0 #17 0xb774a4eb in signal_emit_unlocked_R () from /usr/lib/libgobject-2.0.so.0 #18 0xb774ba20 in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0 #19 0xb774bd89 in g_signal_emit () from /usr/lib/libgobject-2.0.so.0 #20 0xb795acb6 in gtk_container_add () from /usr/lib/libgtk-x11-2.0.so.0 #21 0x08058c51 in xfce_desktop_set_icon_style (desktop=0x80c1858, style=XFCE_DESKTOP_ICON_STYLE_FILES) at xfce-desktop.c:209 #22 0x08059a97 in xfce_desktop_settings_load_initial (desktop=0x80c1858, mcs_client=0x80a33c0) at xfce-desktop-settings.c:239 #23 0x080542e6 in main (argc=1, argv=0xbfc1aa44) at main.c:327 Reproducible: Always Steps to Reproduce: 1.Build Xfdesktop from SVN 2.Run xfdesktop 3.
Thanks for the trace, should be fixed in SVN. Reopen if not.
*** Bug 1734 has been marked as a duplicate of this bug. ***
Partially fixed now it crashes with r click on device icon
Created attachment 536 correct a few more segfaults rodrigo see if this fixes the crashes when trying to mount, execute, right click the icon.
Created attachment 537 update to previous patch. this updates the previous patch to make the right click menu not show irrelevant entries after unmount uses goto and bad indentation so the patch is smaller and has fewer whitespace changes
It indeed crashed after clicking on device icon, but Jani patches solved it, I mounted, umounted, ejected and loaded my CDROM and nothing wrong happened. I can't test with other devices (USB, mem key, etc).
Thanks for the patch Jani. I'm not too crazy over the use of goto here (I don't have anything in general against it, but I don't like to use it when not absolutely necessary), so I'll probably restructure that code. It might be clearer/more maintainable to separate handling "normal" icons from removable volume icons (which is what I ended up doing to fix the original crash). Can we figure out how to trigger this? I still can't reproduce these crashes on my box. Oh - is it because you don't have a mount point set up before the volume is mounted? (P.S. In the future, please open new bugs for new crashes.)
Yes, the case when it crashes is when the mountpoint is dynamically created by pmount and there's no info structure associated to the icon. On umount the same dir is deleted. In this case the icon has the info (did not know how to NULL it, or otherwise invalidate it) so I check for unmounted volume as a differentiator instead of icon with no info on it in the places where the execution or right click menu needs to be treated separately. As for goto, as with the lack of indentation in one place, I just put it there so the diff is small and I don't reorganize too much since it takes some more thought to get it right. I don't think the goto should be there either but this patch is little more than a bugreport with the possible areas of crash located (possibly not all though), so a better restructuring is welcome :)
(In reply to comment #8) > As for goto, as with the lack of indentation in one place, I just put it there > so the diff is small and I don't reorganize too much since it takes some more > thought to get it right. I don't think the goto should be there either but this > patch is little more than a bugreport with the possible areas of crash located > (possibly not all though), so a better restructuring is welcome :) Yeah, that's fine. It at least lets me know exactly where the problem is.
Ok, should be fixed in SVN. Please test.