! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
gcc 2.95 (FreeBSD 4) fixes for quicklauncher plugin
Status:
RESOLVED: FIXED
Product:
Xfce4-panel
Component:
Launcher

Comments

Description Oliver Lehmann 2006-05-03 22:57:04 CEST
Please take a look at

http://people.freebsd.org/~oliver/xfce/gcc295-xfce4-quicklauncher-plugin.patch

which contains patches to get the plugin to compile with gcc 2.95. Would be nice
to get them included in SVN.
Comment 1 Benedikt Meurer editbugs 2006-05-29 09:30:41 CEST
Oliver, the patch cannot be applied. Can you check it?

% patch -Np0 < /tmp/gcc295-xfce4-quicklauncher-plugin.patch
Hmm...  Looks like a unified diff to me...
The text leading up to this was:
--------------------------
|--- panel-plugin/callbacks.c.orig      Wed May  3 06:41:43 2006
|+++ panel-plugin/callbacks.c   Wed May  3 06:41:57 2006
--------------------------
Patching file panel-plugin/callbacks.c using Plan A...
Hunk #1 succeeded at 491.
Hmm...  The next patch looks like a unified diff to me...
The text leading up to this was:
--------------------------
|--- panel-plugin/main.c.orig   Thu May  4 00:29:10 2006
|+++ panel-plugin/main.c        Thu May  4 00:50:26 2006
--------------------------
Patching file panel-plugin/main.c using Plan A...
Hunk #1 succeeded at 114 (offset 1 line).
Hunk #2 failed at 147.
Hunk #3 failed at 201.
Hunk #4 failed at 308.
Hunk #5 failed at 346.
Hunk #6 failed at 370.
Hunk #7 succeeded at 397 (offset 1 line).
5 out of 7 hunks failed--saving rejects to panel-plugin/main.c.rej
done
Comment 2 Oliver Lehmann 2006-05-29 14:47:57 CEST
Hi,

I've made it against ftp://ftp.berlios.de/pub/xfce-goodies/panel-plugins/4.4/xfce4-quicklauncher-plugin-1.9.1.tar.bz2
Is that ok for you? Otherwise I would have to install svn+dependencies to make a checkout. Would be cool If I must not do this ;)
Comment 3 Masse Nicolas 2006-05-29 19:34:15 CEST
Hi, I've seen on the mailing list that you had some problem in order to apply the patch. I will take a look right now.
Also I would like to say that I'm still the maintener of the quicklauncher plugin, but since you post it here and not on berlios, I probably did not took the time to read this.
Since we are moving the goodies to the main xfce servers, I hope this kind of problem won't happen anymore. 

Sorry for that, and thanks for the patch ;) 

Bountykiller.
Comment 4 Oliver Lehmann 2006-07-12 20:00:13 CEST
any news here?
Comment 5 Masse Nicolas 2006-07-12 21:17:06 CEST
It's fixed in the svn repo. (I applied your patch manually)
The problem is that i have no time to make a new release these days...
Comment 6 Jasper Huijsmans editbugs 2006-09-24 18:35:36 CEST
(In reply to comment #5)
> It's fixed in the svn repo. (I applied your patch manually)
> The problem is that i have no time to make a new release these days...
> 

Hey, just checking. There has been a release in the mean time, isn't it?
Comment 7 Oliver Lehmann 2006-09-25 04:54:35 CEST
The latest release I know is 1.9.1 from

ftp://ftp.berlios.de/pub/xfce-goodies/panel-plugins/4.4/

which still needs http://people.freebsd.org/~oliver/xfce/gcc295-xfce4-quicklauncher-plugin.patch
Comment 8 Masse Nicolas 2006-09-25 18:40:24 CEST
Well, in fact there wasn't, because when I commit the patch in svn, it was the only change, and I hadn't lot of time for that.
But I recently made some other change, and I'm testing it since one week one my computer ... no crash since, so I think I will post a new release shortly. 
(I hope it will work with gcc 2.95)
Comment 9 Jasper Huijsmans editbugs 2006-09-25 18:47:27 CEST
Ok, no worries. Just checking to make sure we'll have a realease before Xfce 4.4.0 final ;-)
Comment 10 Nick Schermer editbugs 2006-12-20 09:25:15 CET
This patch seems to be applied in the 1.9.2 release. Please re-open of you have still build problems with gcc 2.95.

Bug #1762

Reported by:
Oliver Lehmann
Reported on: 2006-05-03
Last modified on: 2010-11-20

People

Assignee:
Nick Schermer
CC List:
1 user

Version

Version:
Unspecified

Attachments

Additional information