! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
gcc 2.95 (FreeBSD 4) fixed for xfdesktop
Status:
RESOLVED: FIXED
Product:
Xfdesktop
Component:
General

Comments

Description Oliver Lehmann 2006-05-02 21:38:00 CEST
Please take a look at

http://pofo.de/tmp/gcc295-xfdesktop.patch

which contains patches to get xfdesktop to compile with gcc 2.95. Would be nice to get them included in SVN for the next 4.4 BETA.
Comment 1 Brian J. Tarricone (not reading bugmail) 2006-05-02 23:11:28 CEST
Great, thanks.  I'll put it in when I get home tonight.  Can you explain why this change is needed:

+#ifdef HAVE_THUNARX
 G_DEFINE_TYPE_EXTENDED(XfdesktopFileIcon, xfdesktop_file_icon,
                        G_TYPE_OBJECT, 0,
                        G_IMPLEMENT_INTERFACE(XFDESKTOP_TYPE_ICON,
                                              xfdesktop_file_icon_icon_init)
-#ifdef HAVE_THUNARX
                        G_IMPLEMENT_INTERFACE(THUNARX_TYPE_FILE_INFO,
                                              xfdesktop_file_icon_tfi_init)
-#endif
                        )
+#else
+G_DEFINE_TYPE_EXTENDED(XfdesktopFileIcon, xfdesktop_file_icon,
+                       G_TYPE_OBJECT, 0,
+                       G_IMPLEMENT_INTERFACE(XFDESKTOP_TYPE_ICON,
+                                             xfdesktop_file_icon_icon_init)
+                       )
+#endif
Comment 2 Oliver Lehmann 2006-05-03 04:13:02 CEST
Hi Brian,

this "redundancy" is unfortunately needed because of:

xfdesktop-file-icon.c:127: warning: preprocessing directive not recognized within macro arg
xfdesktop-file-icon.c:127: warning: preprocessing directive not recognized within macro arg
xfdesktop-file-icon.c: In function `xfdesktop_file_icon_get_type':
xfdesktop-file-icon.c:123: undefined or invalid # directive
xfdesktop-file-icon.c:126: undefined or invalid # directive
gmake[2]: *** [xfdesktop-xfdesktop-file-icon.o] Error 1
Comment 3 Brian J. Tarricone (not reading bugmail) 2006-05-03 04:33:27 CEST
Ah, understood.  Anyway, committed - thanks for the patch.

Bug #1755

Reported by:
Oliver Lehmann
Reported on: 2006-05-02
Last modified on: 2009-07-14

People

Assignee:
Brian J. Tarricone (not reading bugmail)
CC List:
0 users

Version

Attachments

Additional information