! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
xfce_panel_plugin_set_expand() misbehaves for external plugins
Status:
RESOLVED: FIXED
Product:
Xfce4-panel

Comments

Description Adriano Winter Bess 2006-04-29 21:20:57 CEST
xfce_panel_plugin_set_expand() doesn't work as expected for external plugins. Please consider the 2 patches attached to this bug. Both patches are for the testplugin in xfce4-panel sources.

The first patch enables installation of the plugin and sets the expand capability of the plugin to TRUE. The second patch does the same thing as the first one plus transforms the testplugin into an internal plugin instead of external. Don't apply the second patch over the first one; both should be applied to current trunk. Needs to reautogen after the patches are applied.

Consider the following scenario: 2 panels, one at the bottom and the other at top, both centered and fullwidth (this is my setup with which I've done the tests).

Apply first patch, add testplugin to one of the panels and move it to the other panel. It won't expand anymore, neither if moved back to the original panel.

Apply second patch, add testplugin to one of the panels and move it to the other panel. It expands normally, as expected.
Comment 1 Adriano Winter Bess 2006-04-29 21:24:14 CEST
Created attachment 529 
First patch

Apply with `patch -p0' into testplugin directory.
Comment 2 Adriano Winter Bess 2006-04-29 21:24:57 CEST
Created attachment 530 
Second patch

Apply with `patch -p0' into testplugin directory.
Comment 3 Jasper Huijsmans editbugs 2006-05-01 06:33:17 CEST
Thanks, I need to have a look at that. My guess is that it is some sort of race condition or timing issue with the plug/socket communication. XEMBED is such a pain... :(
Comment 4 Jasper Huijsmans editbugs 2006-05-21 11:53:56 CEST
(In reply to comment #3)
> Thanks, I need to have a look at that. My guess is that it is some sort of race
> condition or timing issue with the plug/socket communication. XEMBED is such a
> pain... :(
> 

Ok, it wasn't that, it was a bug in xfce-panel-external-item.c. Serves me right for trying to blame other people ;-) Fixed in revision 21754. Thanks for the report.

Bug #1738

Reported by:
Adriano Winter Bess
Reported on: 2006-04-29
Last modified on: 2010-11-20

People

Assignee:
Nick Schermer
CC List:
0 users

Version

Attachments

First patch (1.38 KB, patch)
2006-04-29 21:24 CEST , Adriano Winter Bess
no flags
Second patch (2.90 KB, patch)
2006-04-29 21:24 CEST , Adriano Winter Bess
no flags

Additional information