User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.1) Gecko/20060413 Ubuntu/dapper Firefox/1.5.0.1 Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.1) Gecko/20060413 Ubuntu/dapper Firefox/1.5.0.1 - for an usb stick Xfdesktop only shows the icon after it is mounted, unlike when the device is plugged in, unlike thunar. - for it to show up even after mounted I need to refresh the desktop (F5) - similarly when unmounted, the icon remains on the desktop until an F5, and attempts to click on it result in nothing but a brief startup notification feedback instead of mount+launch thunar. - usb stick icon has eject even if in thunar only CDs have that. Reproducible: Always
One bug per bug report, please. Not four. (In reply to comment #0) > - for an usb stick Xfdesktop only shows the icon after it is mounted, unlike > when the device is plugged in, unlike thunar. That's not my experience here. As soon as I plug in my iPod, it shows up on the desktop (and it's still unmounted). On my machine it sometimes takes a good 5-7 seconds for HAL to get notified of the device, though. I would imagine a USB flash drive would be faster. > - for it to show up even after mounted I need to refresh the desktop (F5) Sounds like you're having a problem with FAM or Gamin. Or HAL or DBUS. Not xfdesktop. Works for me. > - similarly when unmounted, the icon remains on the desktop until an F5, The icon doesn't go away when unmounted, and it shouldn't. How would you remount it again? If it isn't going away after you actually remove the device, then it sounds like you're having a problem with FAM or Gamin. Or HAL or DBUS. Not xfdesktop. Works for me. > and attempts to click on it result in nothing but a brief startup > notification feedback instead of mount+launch thunar. Not seeing that here. Unmounted volume -> double click -> opens thunar to the mount point. > - usb stick icon has eject even if in thunar only CDs have that. Yes, I'm a bit confused about that. thunar_vfs_volume_is_ejectable() appears to be returning true for just about everything on my box. Benny, any ideas? (see xfdesktop-icon-view-manager.c:2030) And just to clear something up in the general sense: xfdesktop is not Thunar. If I choose to implement things slightly differently, that's my choice.
(In reply to comment #1) > One bug per bug report, please. Not four. > I just wanted to make sure they're bugs first. Turns out it could be only one bug causing all inconsistencies. > (In reply to comment #0) > > > - for an usb stick Xfdesktop only shows the icon after it is mounted, unlike > > when the device is plugged in, unlike thunar. > > That's not my experience here. As soon as I plug in my iPod, it shows up on > the desktop (and it's still unmounted). On my machine it sometimes takes a > good 5-7 seconds for HAL to get notified of the device, though. I would > imagine a USB flash drive would be faster. > ok I need to investigate this then. But other usb devices here are as slow to get noticed as well. > > - for it to show up even after mounted I need to refresh the desktop (F5) > > Sounds like you're having a problem with FAM or Gamin. Or HAL or DBUS. Not > xfdesktop. Works for me. > thunar is started and it reacts to them being inserted so gam is running. > > - similarly when unmounted, the icon remains on the desktop until an F5, > > The icon doesn't go away when unmounted, and it shouldn't. How would you > remount it again? If it isn't going away after you actually remove the I agree with it being there. It's just that it goes away after F5. > And just to clear something up in the general sense: xfdesktop is not Thunar. > If I choose to implement things slightly differently, that's my choice. I already knew that. Just want to know which are choices and which are bugs :)
> Yes, I'm a bit confused about that. thunar_vfs_volume_is_ejectable() appears > to be returning true for just about everything on my box. Benny, any ideas? > (see xfdesktop-icon-view-manager.c:2030) Stupid question probably, but does it work in Thunar? I.e. do you see eject in Thunar? If not, please attach the HAL dump of the CD drives.
Created attachment 517 cd udi from lshal Yes in thunar the usb stick has no eject. Here's the CD driver's lshal dump. I'll also try woth today's svn
(In reply to comment #4) > Created an attachment (id=517) [edit] > cd udi from lshal > > Yes in thunar the usb stick has no eject. Here's the CD driver's lshal dump. > I'll also try woth today's svn That was actually for Brian. ;-) Nevertheless, if it works in Thunar, thunar_vfs_volume_is_ejectable() seems to work properly. I'll try to look at the xfdesktop source.
Created attachment 526 eject menu item thunar only shows eject if volume is a disc. I took the liberty of using the same mnemonic as thunar for eject. _j instead of _E. Whichever is ok but at least in such details it'd be nice for the core apps to be consistent with each other.
update: the reason an icon does not show up for the usbstick is because its directory in media is created/deleted as needed by pmount-hal. I guess that you have your ipod mount directory always present. so if the dir does not yet exist /* presumably the mount point is local, so don't worry about delays */ info = thunar_vfs_info_new_for_path(path, NULL); returns NULL and the volumes-added callback returns without showing anything. thunar does not need the vfsinfo apparently for showing the media icon, while xfdesktop needs it since it's an argument to icon create.
(In reply to comment #6) > Created an attachment (id=526) [edit] > eject menu item Applied, thanks. > the reason an icon does not show up for the usbstick is because its > directory in media is created/deleted as needed by pmount-hal. This should be fixed now as well, though I haven't tested it. Please REOPEN if not.
at line 2346: g_hash_table_replace(fmanager->priv->icons, thunar_vfs_path_ref(info->path), icon); segfaults whenever a new removable is detected.
That's a separate bug. Please open a new one.
> This should be fixed now as well, though I haven't tested it. Please REOPEN if > not. > this did not fix it since it does not get to displaying the icon, it crashes first. So it is not a separate bug.
Jesus christ, just do what I ask. You don't need to be an insolent jackass about it.