Hello, I think I found a small regression within last preferences.ui changes as in this commit: https://git.xfce.org/apps/xfce4-terminal/commit/?id=52a309ed70a2c86af71fa17be22cd8bc816c85f2 The preferences.ui is now part of the executable (a good idea) but the ui.h file will still be installed in the datadir "/usr/share/xfce4/terminal" as I believe. This file is not needed to be installed anymore and thus should be left out from installation. Though it still needs to be distributed in a release tarball. I think the parts around this one: ;--- @@ -80,7 +81,7 @@ endif uidir = $(datadir)/xfce4/terminal ui_DATA = \ - terminal-preferences.ui + terminal-preferences-ui.h ## ## Rules to auto-generate built sources @@ -107,11 +108,11 @@ DISTCLEANFILES = \ ;--- are related. There is no need for this specific ui_DATA anymore. Could you please review my thoughts ?
Romain Bouvier referenced this bugreport in commit 0842e1145271444ed1fa4b063c7ffdb3eff01fe6 Bug #16875: Do not add ui.h file in datadir https://gitlab.xfce.org/apps/xfce4-terminal/commit/0842e1145271444ed1fa4b063c7ffdb3eff01fe6
Thank you !