! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
reserved identifier violation
Status:
RESOLVED: MOVED

Comments

Description Markus Elfring 2020-05-14 18:49:00 CEST
I would like to point out that identifiers like “__XFCONF_H__” and “_XfconfDaemon” do not fit to the expected naming convention of the C language standard.
* https://gitlab.xfce.org/xfce/xfconf/-/blob/9ec67fb671b488a81f837e9127719b0bf5027624/xfconf/xfconf.h#L21
* https://gitlab.xfce.org/xfce/xfconf/-/blob/9ec67fb671b488a81f837e9127719b0bf5027624/xfconfd/xfconf-daemon.h#L35

Would you like to adjust the selection for unique names?
https://www.securecoding.cert.org/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier
Comment 1 Git Bot editbugs 2020-05-25 23:51:04 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/xfconf/-/issues/10.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #16849

Reported by:
Markus Elfring
Reported on: 2020-05-14
Last modified on: 2020-05-25

People

Assignee:
Xfce Bug Triage
CC List:
0 users

Version

Version:
4.14.1

Attachments

Additional information