! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[Wayland] Thunar crashes when using a custom action with startup notification...
Status:
RESOLVED: MOVED
Product:
Libxfce4ui
Component:
General

Comments

Description nj 2020-04-27 20:40:04 CEST
Created attachment 9808 
gdb backtrace
Comment 1 alexxcons editbugs 2020-04-28 16:52:59 CEST
Thanks for reporting !

I' ll have a look when I have time.
Comment 2 alexxcons editbugs 2020-04-28 17:58:53 CEST
moved to libxfce4ui, since xfce_spawn_on_screen_with_child_watch is defined there
Comment 3 alexxcons editbugs 2020-04-28 19:17:11 CEST
Created attachment 9814 
prevent crash by disable feature

The crashing "sn_display_new" is part of the optional library "libstartup-notification".

Theoretically it should be sufficient to just drop the dependency to "libstartup-notification", since gtk meanwhile seem to be able to handle that on its own:
https://developer.gnome.org/integration-guide/stable/startup-notification.html.en
https://developer.gnome.org/gdk3/stable/gdk3-General.html#gdk-notify-startup-complete

Practically as far as I can tell, this seems not to work for processes started via 'g_spawn_async'.

Theoretically  "libstartup-notification" is optional, you can take a try to just uninstall the package ... practically it seems to be used by many other packages :/

Another possible fix is to just dont do startup notifications in wayland, and instead print a warning into console (if thunar runs from console) ... thats what I tried to do in the attached patch.

So far I did not try to run wayland at my own .. though afaik checking for "XDG_SESSION_TYPE" == "wayland" seems to work as a probe. See:
https://git.xfce.org/xfce/thunar/commit/?id=660d9ceb8509ef82fe3a4a0287014010286bf12c

Please take a try for the attached patch if you can, and let me know if it worked ! (You will need to build libxfce4ui from source, install it, and restart thunar with thunar -q;thunar)
Comment 4 Git Bot editbugs 2020-05-25 23:03:38 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/libxfce4ui/-/issues/17.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #16769

Reported by:
nj
Reported on: 2020-04-27
Last modified on: 2020-05-25

People

Assignee:
Xfce Bug Triage
CC List:
1 user

Version

Attachments

gdb backtrace (2.74 KB, text/plain)
2020-04-27 20:40 CEST , nj
no flags
prevent crash by disable feature (1.09 KB, patch)
2020-04-28 19:17 CEST , alexxcons
no flags

Additional information