! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
symbolic icons in notification area do not change colour in dark themes
Status:
RESOLVED: INVALID
Product:
Xfce4-panel
Component:
Notification Area

Comments

Description Peter F. Patel-Schneider 2020-04-21 23:53:23 CEST
Created attachment 9773 
screenshot of notification area with symbolic icons

Symbolic icons are supposed to change colour in dark themes.  This works fine for regular panel items, but not for symbolic icons in the notification area.
I noticed this from a Python program using app indicator 3.  I don't believe that the bug is in app indicator 3, but I don't know how to see what the icon_name is that the notification area requests from the program via DBus.
Comment 1 Peter F. Patel-Schneider 2020-04-21 23:54:43 CEST
Created attachment 9774 
Python program that exhibits the problem
Comment 2 Peter F. Patel-Schneider 2020-04-23 13:48:59 CEST
It would be useful to allow the icons to be styled.  As it stands right now I do not see any way to style notification icons at all - they do not get any classes from the application and there is no special class for them otherwise.
Comment 3 Simon Steinbeiss editbugs 2020-04-27 22:48:26 CEST
The notification area only supports sysmbolic icons since version 4.15.2 and currently needs a panel restart to apply such style changes. Maybe this can be fixed, but I didn't consider it a priority. So patches are welcome!
Comment 4 Peter F. Patel-Schneider 2020-04-27 22:55:44 CEST
I also would not consider this a priority.  

How can I install and use 4.15 under Fedora?
Comment 5 Simon Steinbeiss editbugs 2020-04-27 23:00:23 CEST
I literally have zero idea because I don't use Fedora. You can either ask someone from the Fedora community or if you only want to test use the xfce-test docker container.
Also beware that 4.15 isn't a stable release yet, we're currently working on our next stable 4.16.
Comment 6 Peter F. Patel-Schneider 2020-04-27 23:20:07 CEST
OK, I guess then my question is whether anything special needs to be done to compile the 4.15 panel.
Comment 7 Peter F. Patel-Schneider 2020-04-28 00:02:32 CEST
I think I have xfce4-panel 4.15.2 installed in 4.14.  Is that supposed to work?  If so, I'm not seeing the symbolic icons change color when I change from Adwaita to Adwaita-dark.
Comment 8 Peter F. Patel-Schneider 2020-04-28 00:05:57 CEST
Hmm, maybe not.  I did a restart and the icon has changed color to white (but when I think it shouldn't).  I then changed to Adwaita-dark and the icon shows up correctly.  So it looks as if the changing is sort of working.
Comment 9 Simon Steinbeiss editbugs 2020-05-27 12:32:05 CEST
Yup, this sounds like the current limitation with symbolic icon support (requires restart).

Bug #16733

Reported by:
Peter F. Patel-Schneider
Reported on: 2020-04-21
Last modified on: 2020-05-27

People

Assignee:
Xfce Bug Triage
CC List:
1 user

Version

Version:
4.14.0

Attachments

screenshot of notification area with symbolic icons (19.13 KB, image/png)
2020-04-21 23:53 CEST , Peter F. Patel-Schneider
no flags
Python program that exhibits the problem (633 bytes, text/x-python)
2020-04-21 23:54 CEST , Peter F. Patel-Schneider
no flags

Additional information