! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Incorrect folder highlit in sidebar when using Go, Places shortcuts
Status:
RESOLVED: WONTFIX

Comments

Description Simon Dedman 2020-04-21 06:57:36 CEST
Created attachment 9765 
PIC1 screenshot

With Tree sidebar, clicking Go and selecting a shortcut opens that folder in the right pane, but doesn't drill all the way down to that location in the tree in the sidebar, and also highlights the wrong folder.

E.g.: I selected the abft_diving folder in go/places, but the tree only expands to two levels above the target folder (Work). And it has highlit Win10, the NEXT top-level item after the intended target.

see PIC1
Comment 1 Simon Dedman 2020-04-21 07:00:21 CEST
Created attachment 9766 
screenshot2

pic2: if I doubleclick a subfolder in the right pane it goes there but in the sidebar the tree expands to the same second tier branch but in /media rather than the usual drive folder
Comment 2 Simon Dedman 2020-04-21 07:06:10 CEST
Created attachment 9767 
PIC3 screenshot

If I subsequently go to the same shortcut via the Go menu again, it goes to the correct place in the right pane (again) but this time the sidebar tree still has the /media branch open and has again highlit the next top level item (simon).

In general this ends up having /media open for everything, as well as the original drive folders, meaning the sidebar menu is a duplicated mess.

Happy to try other things to reproduce more odd behaviour, just let me know. FWIW that Seagate drive is formatted as ntfs but this also happens with other folders.
Comment 3 alexxcons editbugs 2020-04-21 08:40:15 CEST
Thanks for reporting.

> screenshot1
I cannot reproduce this one .. though I can confirm that there is some problem. The tree-view is not expanded at all, if the wrong root-node in the tree is selected. (however thats not the bug you reported)

> screenshot2
Not clear to me which folder you clicked in the right pane .. its a bit cumbersome to guess that from your text and the screenshot. Could you please write which folder(URI) you clicked, and which one got opened? Isnt this bug about the go menu ?

> screenshot3
> If I subsequently go to the same shortcut via the Go menu again ...
I cannot reproduce either .. for me all my shortcuts are directly opened. Could you please be a bit more concrete ? To which path the shortcut points ? Which path was opened in the tree-view ? Which one was opened on the right pane ?

You are really on thunar 1.8.13 ? .. Asking, because it has some DragAndDrop issues for multiple files. Thats why I released 1.8.14 directly on the next day.
Comment 4 Simon Dedman 2020-04-21 09:17:47 CEST
Hi Alex,

So if I fire up a fresh instance of Thunar, my home folder is highlit in the sidepane tree and its contents are in the right pane.

Go > abft_diving now goes to the right place and opens up the tree branches correctly. This is part of the problem and why I haven't reported this until now even though it's been an issue for a while: the behaviour doesn't seem to be the same all the time.

Ok, then I tried Go>Downloads. Right pane: home/simon/downloads (correct). Left tree: File System/home/simon/Downloads (wrong)

Go>Abft_diving (again): right pane & address bar both correct again, left tree is the File System root (wrong).

Go>home: correct right & left. Go>downloads: also correct right & left. It feels like it's searching for the next occurrence of that named folder, depending on the starting highlight location.

There is also an odd issue with the sidepane whereby the highlight seems 'sticky' - attempting to collapse branches is often resisted if a subfolder is selected. Again, I now can't get this to fail so it's hard to give a proper stepwise example. I'll install 1.8.14 tomorrow and let you know if that changes anything.

Cheers!
Comment 5 Simon Dedman 2020-04-21 09:44:40 CEST
Hi again,
Just installed 1.8.14 and the behaviour's the same:

click go>abftdiving & right pane contents correct. Address is /media/Seagate/... i.e. Seagate isn't listed as top level (which may be normal?). Sidepane: home folder highlit, Seagate/Work tree expanded but not all the way, only two clicks deep.

go>photos: right pane correct, address bar /media/Seagate/photos. sidebar: seagate/photos highlit. All correct. But tree was already open which may be informative.

go>dropbox: right pane correct, address correct (/home/simon/dropbox), sidebar wrong (File System/home/...)

go>photos: right & address correct. Sidepane: File System/media/Seagate/photos = wrong. Again filesystem folder already open, and previously highlit folder was in filesystem.

manually select Home in sidepane

go>dropbox: right pane correct, address correct (/home/simon/dropbox), sidebar correct (Simon/Dropbox highlit).

Possibly 2 bugs:
1. when clicking a shortcut, the highlit folder depends on the current location, and
2. Thunar treats typical paths (/home, /Seagate) the same as the File System mirrors in the sidebar tree, and doesn't preferentially select the former.

Hope this helps a bit. I'm counting the minutes until the official release of 20.04 so I can do a fresh install and hopefully wash away a lot of these bugs!
Comment 6 Theo Linkspfeifer editbugs 2020-04-21 13:10:08 CEST
Bug 16024 is probably relevant for this report.

There is a pending fix also:
https://bugzilla.xfce.org/show_bug.cgi?id=15762#c15
Comment 7 Simon Dedman 2020-04-21 17:46:28 CEST
Thanks Theo!
Comment 8 alexxcons editbugs 2020-04-22 10:32:05 CEST
Thanks for the details !

(In reply to Simon Dedman from comment #4)
> Hi Alex,
> 
> So if I fire up a fresh instance of Thunar, my home folder is highlit in the
> sidepane tree and its contents are in the right pane.
> 
> Go > abft_diving now goes to the right place and opens up the tree branches
> correctly. This is part of the problem and why I haven't reported this until
> now even though it's been an issue for a while: the behaviour doesn't seem
> to be the same all the time.
"Sometimes folder is not opened" most likely will be fixed with https://bugzilla.xfce.org/show_bug.cgi?id=15762#c12

> Ok, then I tried Go>Downloads. Right pane: home/simon/downloads (correct).
> Left tree: File System/home/simon/Downloads (wrong)
Not using /home/* is expected here. If some tree is already open, that tree will be used. Thats a result of the fix from Bug #16024 

> Go>Abft_diving (again): right pane & address bar both correct again, left
> tree is the File System root (wrong).
Possibly fixed by https://bugzilla.xfce.org/show_bug.cgi?id=15762#c15


(In reply to Simon Dedman from comment #5)
> click go>abftdiving & right pane contents correct. Address is
> /media/Seagate/... i.e. Seagate isn't listed as top level (which may be
> normal?). Sidepane: home folder highlit, Seagate/Work tree expanded but not
> all the way, only two clicks deep.
Again "Sometimes folder is not opened" most likely will be fixed with https://bugzilla.xfce.org/show_bug.cgi?id=15762#c12

> go>dropbox: right pane correct, address correct (/home/simon/dropbox),
> sidebar wrong (File System/home/...)
Again not using /home/* is expected here. If some tree is already open, that tree will be used. Thats a result of the fix from Bug #16024

> Possibly 2 bugs:
> 1. when clicking a shortcut, the highlit folder depends on the current
> location
Yes, as mentioned, actually thats a feature (Bug #16024) ;) 

> 2. Thunar treats typical paths (/home, /Seagate) the same as the File System
> mirrors in the sidebar tree, and doesn't preferentially select the former.
Possibly fixed with https://bugzilla.xfce.org/show_bug.cgi?id=15762#c12 .. not sure on that. If you can, please take a try for the attached patch.
 
> Hope this helps a bit. I'm counting the minutes until the official release
> of 20.04 so I can do a fresh install and hopefully wash away a lot of these
> bugs!
What official release of 20.04 ? Anyway, not sure if that willhelp :) .. at least 2.) possibly will be fixed in thunar 1.8.15

All in all, if Theo's patch does not fix 2.) for you, I would go for a fresh bug for only 2.) and close this one, since it is already very messed.
Comment 9 Simon Dedman 2020-04-22 17:36:03 CEST
Thanks for the reply Alex.
20.04 is xubuntu 20.04, released tomorrow. But as you say, might not fix anything Thunar related.
I'll try Theo's patch asap and update this bug or start a new one; do you know when 1.8.15 is likely to be pushed?
Comment 10 alexxcons editbugs 2020-04-22 17:46:26 CEST
(In reply to Simon Dedman from comment #9)
> do you know when 1.8.15 is likely to be pushed?
Whenever there is an important fix pending, or just after a while .. usually every 2-3 months
Comment 11 Simon Dedman 2020-04-24 17:22:53 CEST
In case this is useful, back on an old laptop, Thunar 1.8.9 doesn't have this behaviour. Same shortcuts, but no external drives. One of the shortcuts is an SSHFS network drive which opens under File System, BUT, subsequent shortcuts to e.g. Downloads, etc, DON'T go to those folders in File System/home/me etc, they go to the 'proper' top level locations.

Makes me think 

1. It's somewhat related to external drives,
2. It might be possible to diff elements from 1.8.9 to see what's changed (if it's not just #1)

Cheers
Comment 12 alexxcons editbugs 2020-04-24 19:20:21 CEST
(In reply to Simon Dedman from comment #11)
> In case this is useful, back on an old laptop, Thunar 1.8.9 doesn't have
> this behaviour. Same shortcuts, but no external drives. One of the shortcuts
> is an SSHFS network drive which opens under File System, BUT, subsequent
> shortcuts to e.g. Downloads, etc, DON'T go to those folders in File
> System/home/me etc, they go to the 'proper' top level locations.
> 
> Makes me think 
> 
> 1. It's somewhat related to external drives,
Yes, when playing with remote drives ... think now I found something which can be considered as bug:
1. open thunar and the tree view.
2. Open an usb drive in the tree view
3. Use the Shortcut Go --> Pictures
Expected: $Home->Pictures is opened in tree-view
Actual:    Filesystem->home->user->Pictures is opened

... I'll open a new bug for it. Guess you currently cant test yourself :/
Comment 13 Simon Dedman 2020-04-24 19:24:54 CEST
:( indeed!

But great work on narrowing it down. On 1.8.9:

1. Go>Downloads opens in expected place
2. Insert usb drive
3. Open in tree view
4. Go>Downloads still opens in expected place (i.e. top not File System)

Not sure if this is 100% the same (I don't have Pictures shortcut, guess I deleted it). Cheers!
Comment 14 alexxcons editbugs 2020-04-24 19:33:30 CEST
Go->Download is the same

> ... I'll open a new bug for it. Guess you currently cant test yourself :/

I was to fast .. its already fixed in master, only a problem in 1.8.14 .. hope that fixes as well your problem.

If you like, you can take a try to compile thunar from source and see if it is fixed stuff for you: https://wiki.xfce.org/thunar/dev/build_and_run

(There is as well this docker container, if you prefer: https://hub.docker.com/r/schuellerf/xfce-test
Comment 15 Theo Linkspfeifer editbugs 2020-04-24 19:37:24 CEST
Hint: https://bugzilla.xfce.org/show_bug.cgi?id=15762#c15

Bug #16730

Reported by:
Simon Dedman
Reported on: 2020-04-21
Last modified on: 2020-04-24

People

Assignee:
Xfce Bug Triage
CC List:
3 users

Version

Version:
1.8.13

Attachments

PIC1 screenshot (137.19 KB, image/png)
2020-04-21 06:57 CEST , Simon Dedman
no flags
screenshot2 (397.38 KB, image/png)
2020-04-21 07:00 CEST , Simon Dedman
no flags
PIC3 screenshot (169.72 KB, image/png)
2020-04-21 07:06 CEST , Simon Dedman
no flags

Additional information