! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
The thumbnail background uses a fixed color
Status:
RESOLVED: MOVED
Severity:
enhancement
Product:
Ristretto
Component:
Application

Comments

Description Roland Pfeifer 2020-04-19 13:27:29 CEST
Created attachment 9756 
patch that adds setting to choose thumbnail background color behaviour

The added patch allows choosing if the default behaviour shoud be retained, or if the theme background color or the choosen background color shoud be used.
Comment 1 Theo Linkspfeifer editbugs 2020-04-19 17:51:58 CEST
The patch works. However, applying it gives the following warnings:

Applying: allow unified background for thumbnails
.git/rebase-apply/patch:11: trailing whitespace.
        GObject *settings, 
.git/rebase-apply/patch:12: trailing whitespace.
        GParamSpec *pspec, 
.git/rebase-apply/patch:17: trailing whitespace.
        RsttoIconBar *icon_bar, 
.git/rebase-apply/patch:26: trailing whitespace.
    
.git/rebase-apply/patch:39: trailing whitespace.
            icon_bar->priv->settings);    
warning: squelched 26 whitespace errors
warning: 31 lines add whitespace errors.
Comment 2 Roland Pfeifer 2020-04-20 17:58:59 CEST
Created attachment 9760 
corrected trailing whitespace, naming, free
Comment 3 Roland Pfeifer 2020-04-21 15:32:28 CEST
Created attachment 9769 
minor correction
Comment 4 Git Bot editbugs 2020-05-25 00:34:06 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/apps/ristretto/-/issues/36.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #16718

Reported by:
Roland Pfeifer
Reported on: 2020-04-19
Last modified on: 2020-05-25

People

CC List:
1 user

Version

Version:
0.10.0

Attachments

Additional information