Created attachment 9737 screenshot Steps: 1. open thunar 2. plugin your phone and a USB drive 3. mount the phone and USB drive 4. mount an internal partition 5. notice either only the USB drive has an unmount arrow
This is not an "unmount arrow", but an eject button. It is shown when the Eject action is available (see context menu).
Created attachment 9745 file dialog Yes i guess that is correct, but what do we do about the inconsistency with the file dialogs which has it for unmount for things that cant be ejected.
Created attachment 9748 thunar vs caja Similarly caja uses the arrow to indicate that a partition is mounted instead of dimming it in the sidebar.
Created attachment 9749 thunar vs caja (corrected)
Created attachment 9750 thunar vs caja (corrected)
(In reply to Jay Philips from comment #2) > Created attachment 9745 > file dialog > > Yes i guess that is correct, but what do we do about the inconsistency with > the file dialogs which has it for unmount for things that cant be ejected. Which file dialogs are you referring to ? I tried the GtkFileChooserDialog from firefox .. seems to behave the same way than thunar when I plug-in my android phone .. no eject button shown. Or do I get it wrong ?
Created attachment 9755 full file dialog (In reply to alexxcons from comment #6) > Which file dialogs are you referring to ? The gtk3 file dialogs. > I tried the GtkFileChooserDialog from firefox .. seems to behave the same > way than thunar when I plug-in my android phone .. no eject button shown. Or > do I get it wrong ? My screenshot was from the 'Other Locations' section. I've attached a screenshot now for the main file dialog and you can see my s7 has an eject/unmount button. It didnt when i first plugged it in, but once it was mounted, the arrow showed up.
(In reply to Yousuf 'Jay' Philips from comment #7) > My screenshot was from the 'Other Locations' section. I've attached a > screenshot now for the main file dialog and you can see my s7 has an > eject/unmount button. It didnt when i first plugged it in, but once it was > mounted, the arrow showed up. Ops, haha, I just have to select it to as well get that arrow, sorry :) If I get that correct, the gtk3 dialog does a bad job. The arrow is always called "unmount". On my smartphone that seems to work fine. Clicking on it after unmount will just re-mount the phone. But on an usb flashdrive pressing it will result in a ejecting the stick, I have to plug it out and re-insert it ... not exactly what I expected, since the tooltip says "unmount". So I dont think that we should follow that approach, which does not differ at all between unmount and eject. I would rather open a bug aganist GtkFileChooserDialog to ask them to differ between eject and unmount. Therefore "wontfix" for this bug. Though I guess we could improve thunar by showing a tooltip "eject" on the eject button to better reflect its purpose .. if you like that ide, feel free to open a new bug for it !
(In reply to alexxcons from comment #8) > So I dont think that we should follow that approach, which does not differ > at all between unmount and eject. I would rather open a bug aganist > GtkFileChooserDialog to ask them to differ between eject and unmount. > Therefore "wontfix" for this bug. The gtk3 dialog is only one place, but as mentioned, this is the behaviour in Caja. I checked and Nemo and Nautilus also have this behaviour, so should bugs be filed against all these file managers? The focus of this bug report is to make it easy to unmount partitions that can't be ejected, rather than having to rely on the context menu.
(In reply to Yousuf 'Jay' Philips from comment #9) > The focus of this bug report is to make it easy to unmount partitions that > can't be ejected, rather than having to rely on the context menu. I got the impression that the idea is that thunar should just behave like the other file managers/dialogs :) So what would be your concrete proposal to ease unmount ? Best open a new bug for it. What I could imagine is to use the current icon for unmount (seems like anyhow everybody uses the "eject" icon for both), and only allow to eject via context menu. In any case IMO it would make much sense to have a tooltip on that icon to be able to check its purpose. Though I would not want to eject stuff if "unmount" is pressed, like done in the other file-managers.
(In reply to alexxcons from comment #10) > I got the impression that the idea is that thunar should just behave like > the other file managers/dialogs :) If other file managers provide a better/simpler UX, definitely it should IMO. > So what would be your concrete proposal to ease unmount ? Best open a new > bug for it. Eject for removables and umount for non-removables. > What I could imagine is to use the current icon for unmount (seems like > anyhow everybody uses the "eject" icon for both), and only allow to eject > via context menu. That wouldn't make things better, that we make it harder for USBs to be ejected. > In any case IMO it would make much sense to have a tooltip on that icon to > be able to check its purpose. Definitely useful if people would wait around to let it appear, which people wont. > Though I would not want to eject stuff if "unmount" is pressed, like done in > the other file-managers. We could show a different icon to distinguish between the two operations, if that is what is acceptable.