! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
simplify default panel config makefile to avoid need to autoreconf on every c...
Status:
RESOLVED: FIXED
Product:
Xfce4-panel

Comments

Description Jani Monoses 2006-04-17 16:59:03 CEST
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.1) Gecko/20060324 Ubuntu/dapper Firefox/1.5.0.1
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.1) Gecko/20060324 Ubuntu/dapper Firefox/1.5.0.1

With this change one can add/remove launcher files in config without needing to tweak the makefile again. Helps in distro packaging too since there is no need to autoreconf and create spurious build file differences against upstream if one
wants to provide different default panel config.
The wildcard propagates nicely up to the final makefile so this should be safe.

Index: config/Makefile.am
===================================================================
--- config/Makefile.am  (revision 21050)
+++ config/Makefile.am  (working copy)
@@ -1,8 +1,4 @@
 confdir = $(sysconfdir)/xdg/xfce4/panel
-conf_DATA = panels.xml \
-           launcher-7.rc \
-           launcher-8.rc \
-           launcher-9.rc \
-           launcher-10.rc
+conf_DATA = panels.xml launcher-*.rc

 EXTRA_DIST = $(conf_DATA)


Reproducible: Always
Comment 1 Jasper Huijsmans editbugs 2006-04-20 20:16:50 CEST
Hmm, I didn't know you could do that ;-) On one hand I really like this change for its simplicity, but on the other hand I also like the fact that you must specifically choose the files that will be installed.

I'll think about it...
Comment 2 Jasper Huijsmans editbugs 2006-08-01 18:42:36 CEST
I believe this is fixed now (with *.rc.in).

Bug #1671

Reported by:
Jani Monoses
Reported on: 2006-04-17
Last modified on: 2010-11-20

People

Assignee:
Nick Schermer
CC List:
0 users

Version

Attachments

Additional information