! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Enhancement: Add option to xfwm4 to have mouse wheel lower/raise windows in a...
Status:
RESOLVED: MOVED
Severity:
enhancement

Comments

Description Zachary Sample 2020-04-08 06:22:55 CEST
Created attachment 9685 
Patch to add mousewheel_lower option.

I just switched from LXDE (with openbox) to XFCE (with XFWM). Under openbox, scrolling the mouse wheel up on a window's title bar rolls-up the window (shades the window) as well as unfocusing it and lowering it. I utilized this to have multiple windows in the same place, and to change between them I would quickly scroll up then down over the title bar location.

Under XFCE there is a setting that makes scrolling up on the mouse wheel over a window's title bar shade/roll-up the window, but does not remove focus from the window or lower the window.

I am submitting a basic patch (from commit af7db8ee2dc75c77dbd1011bdf8b970c452eca8d ) to add this feature (as the "mousewheel_lower" option), as well as a checkbox for the option in xfwm-tweaks-dialog under the "mousewheel_rollup" option's checkbox. 

This patch adds a new translatable string for the option description (in settings-dialogs/xfwm4-tweaks-dialog.glade), but I don't know how localization works, so this patch does not add the string to the localization.
Comment 1 Zachary Sample 2020-04-16 12:17:38 CEST
The patch I submitted does not work if there are no other non-shaded windows on the workspace. It seems that if there are no other unshaded windows on the workspace, clientLower does not actually lower the window (or maybe it does, then immediately raises it again?).
Comment 2 Zachary Sample 2020-04-16 12:39:16 CEST
Correction: The patch I submitted does not work if there are no other non-shaded windows on the workspace *and* the raise_on_focus setting is enabled. It seems that if there are no other unshaded windows on the workspace, clientLower lowers the window, but the window is still the most eligible window for focus, so it regains focus and is raised again (?).
If raise_on_focus is disabled, this patch works as intended even if there are no other windows on the workspace.
Comment 3 Git Bot editbugs 2020-05-29 12:47:59 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/xfwm4/-/issues/382.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #16651

Reported by:
Zachary Sample
Reported on: 2020-04-08
Last modified on: 2020-05-29

People

Assignee:
Olivier Fourdan
CC List:
0 users

Version

Version:
GIT Master

Attachments

Patch to add mousewheel_lower option. (8.03 KB, patch)
2020-04-08 06:22 CEST , Zachary Sample
no flags

Additional information