The popup menu does not appear when pressing and holding the left button on either "<-" or "->" in the location bar. $ thunar (thunar:9275): Gtk-WARNING **: 23:33:35.434: no trigger event for menu popup (thunar:9275): Gtk-CRITICAL **: 23:33:35.434: gtk_menu_popup_at_rect: assertion 'GDK_IS_WINDOW (rect_window)' failed
Interesting, did not know that it existed :) .. probably broke during gtk3 port. Fix should be done after https://github.com/andreldm/thunar/tree/ReplaceGtkAction got merged .. since I messed with the History Actions. (Or now, directly on the "ReplaceGtkAction" branch)
Same as: https://bugzilla.xfce.org/show_bug.cgi?id=14583#c12
Created attachment 9647 diff The functionality is gone when compiling Thunar from the linked branch. No more popup on left-click (long press) or right-click. The attached diff fixes the bug in git master.
thunar-history-action.c does not exist any more in the "ReplaceGtkAction" branch ... I'll rather see how to fix that in the branch, instead of adding dtuff to master which anyhow will be replaced soon.
Probably can be done by listening to "button-release-event" and checking the event->time in the handler (struct GdkEventButton) Its in thunar-window.c:750 and thunar-window.c:3690 Rebased, most recent version of the WIP branch: https://github.com/alexxcons/thunar/tree/ReplaceGtkAction2
Does this mean that the bug will stay unfixed in 1.8?
(In reply to Theo Linkspfeifer from comment #6) > Does this mean that the bug will stay unfixed in 1.8? Uh, true, completely forgot about 4.14 for this one. Though I will wait until there is as well a solution for master. I dont want to re-introduce the feature on 4.14 if that could introduce a regression for master.
(In reply to Theo Linkspfeifer from comment #3) > Created attachment 9647 > diff > > The functionality is gone when compiling Thunar from the linked branch. No > more popup on left-click (long press) or right-click. Popup on right-click is fixed in the most recent branch: https://github.com/alexxcons/thunar/tree/ReplaceGtkAction45 Though so far no support for long press in the WIP branch
-- GitLab Migration Automatic Message -- This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/thunar/-/issues/289. Please create an account or use an existing account on one of our supported OAuth providers. If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev