! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Icon inconsistency on message dialog
Status:
RESOLVED: INVALID

Comments

Description ignaciop.3 2020-03-22 23:26:22 CET
Created attachment 9630 
Thunar dialog icon

Hi, I noticed some icon differences between message dialogs on Xubuntu 20.04 daily build. Apparently it uses the same icon but with different style. In the attached image there is an example from Thunar (upper left) and Terminal (lower right).

Personally, I think it is better the one in the Terminal dialog.

Thank you for your excellent work on Xfce!
Comment 1 alexxcons editbugs 2020-03-23 23:28:38 CET
On thunar master the "empty trash" dialog does not show an icon for me at all, so I assume there is nothing to do.

I assume that a gtk version change might be responsible for the now "missing" icon, since actually thunar does not explicitly specify a icon:

thuanr -application.c:2337 (thunar_application_empty_trash) :

  dialog = gtk_message_dialog_new (window,
                                   GTK_DIALOG_MODAL
                                   | GTK_DIALOG_DESTROY_WITH_PARENT,
                                   GTK_MESSAGE_QUESTION,
                                   GTK_BUTTONS_NONE,
                                   _("Remove all files and folders from the Trash?"));

Probably the Icon is added automatically by "GTK_MESSAGE_QUESTION".
So possibly xfce4-terminal should just switch to use gtk_message_dialog_new with  GTK_MESSAGE_QUESTION, instead of adding a custom icon.

Bug #16588

Reported by:
ignaciop.3
Reported on: 2020-03-22
Last modified on: 2020-03-23

People

Assignee:
Xfce Bug Triage
CC List:
1 user

Version

Version:
1.8.11

Attachments

Thunar dialog icon (206.84 KB, image/jpeg)
2020-03-22 23:26 CET , ignaciop.3
no flags

Additional information