! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Rename "Disconnect" context menu entry in side pane
Status:
RESOLVED: FIXED
Priority:
Medium
Severity:
normal
Product:
Thunar
Component:
General

Comments

Description Theo Linkspfeifer editbugs 2020-03-16 00:31:18 CET 
I suggest to rename the action for ejecting local and remote mounts (same entry internally) from "Disconnect" to "Unmount". Reference: Nautilus and co.
Comment 1 alexxcons editbugs 2020-03-16 23:00:52 CET 
Ok for me to rename, seems to be common across nautilus, nemo, dolphin, caja and pcmanfm.
Though I have trouble testing it for local mounts.

For a sftp mount to some remote, I see what you refer to. Though what would be a local mount to test ?

I have two USB flashdrives connected, both only offer "eject" and "unmount" to me.
Comment 2 Theo Linkspfeifer editbugs 2020-03-16 23:57:34 CET 
VirtualBox shared folder for example.
Comment 3 alexxcons editbugs 2020-03-18 19:46:41 CET 
Ok, I see ... fine for me than.

... where was that patch again ?
Comment 4 Theo Linkspfeifer editbugs 2020-03-18 20:05:03 CET 
Created attachment 9615 
patch
Comment 5 Git Bot editbugs 2020-03-18 23:00:18 CET 
Theo Linkspfeifer referenced this bugreport in commit 773ea887b8907722012eecd0d3c8c90765a0310c

Rename "Disconnect" context menu entry in side pane (Bug #16558)

https://git.xfce.org/xfce/thunar/commit?id=773ea887b8907722012eecd0d3c8c90765a0310c
Comment 6 alexxcons editbugs 2020-03-18 23:00:59 CET 
ok, pushed it to master, thanks Theo!

Bug #16558

Reported by:
Theo Linkspfeifer
Reported on: 2020-03-16
Last modified on: 2020-03-18

People

Assignee:
Xfce Bug Triage
CC List:
1 user

Version

Version:
git
Target Milestone:
1.8.13

Attachments

patch (1.95 KB, patch)
2020-03-18 20:05 CET , Theo Linkspfeifer 		no flags

Additional information