! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Regression: Fail to lock on lid close
Status:
RESOLVED: FIXED
Product:
Xfce4-power-manager
Component:
General

Comments

Description Maurizio Galli 2020-03-10 05:34:18 CET
Since update to 1.6.6,  lid close fail to lock or suspend + lock when using xfce4-screensaver. Other lockers don't seem affected by this.

A dialog with following error message appears: "none of the lock tools ran successfully, the screen will not be locked"

Reverting back to 1.6.5, the system returns to a successful lock.

Possible culprit is commit 26d621a8d30c1c2d0fcf56fd89379ef8f9f8ada6
Comment 1 Maurizio Galli 2020-03-10 06:05:41 CET
I confirm that just reverting 26d621a8d30c1c2d0fcf56fd89379ef8f9f8ada6 restores normal laptop lid locking behavior.
Comment 2 Maurizio Galli 2020-03-10 08:55:58 CET
Created attachment 9557 
Proposed patch

xfce4-session needs to be patched as well. I attached a proposal.
Comment 3 Maurizio Galli 2020-03-10 10:23:48 CET
(In reply to Maurizio Galli from comment #2)
> Created attachment 9557 
> Proposed patch
> 
> xfce4-session needs to be patched as well. I attached a proposal.

needs further digging as there are  other unexpected behaviors
Comment 4 Maurizio Galli 2020-03-10 10:49:34 CET
Created attachment 9560 
xfce4-power-manager log
Comment 5 Maurizio Galli 2020-03-10 10:53:30 CET
Created attachment 9561 
xfce4-screensaver log during lid events
Comment 6 laguna 2020-03-11 18:21:17 CET
Created attachment 9575 
xfce-power-manager-log

xfce-power-manager-log
Comment 7 laguna 2020-03-11 19:02:22 CET
Created attachment 9576 
xfce4-screensaver log during lid events
Comment 8 Frash 2020-03-12 10:26:53 CET
Created attachment 9579 
error message

After clicking yes the system goes to hibernate, like it should.
Comment 9 Simon Steinbeiss editbugs 2020-03-24 00:27:09 CET
Created attachment 9634 
xfce4-session: Support xfce4-screensaver

I added another patch for xfce4-session (untested) - maybe MauG you can take it for a spin and also tell me which side-effects you noticed with your own (slightly different) patch.
Comment 10 Maurizio Galli 2020-03-24 04:41:21 CET
Locks screen now appears but suspend fails with the same error dialog. Moreover suspend seems to fail through the session manager too now.
Comment 11 Git Bot editbugs 2020-03-28 13:23:16 CET
Sean Davis referenced this bugreport in commit cc33cea3df2ab361cdbddecfa901fbc048ce278b

Send empty DBus responses (bug #16522)

https://git.xfce.org/apps/xfce4-screensaver/commit?id=cc33cea3df2ab361cdbddecfa901fbc048ce278b
Comment 12 Sean Davis editbugs 2020-03-28 13:24:07 CET
Combine the session patch with the screensaver commit just above, and this issue should be resolved. Please confirm.
Comment 13 Maurizio Galli 2020-03-28 15:10:10 CET
(In reply to Sean Davis from comment #12)
> Combine the session patch with the screensaver commit just above, and this
> issue should be resolved. Please confirm.

It works! No more error messages nor failures. Thank you for fixing this issue!

Unless there is some side effect coming up, I will close this as resolved:fixed
Comment 14 Simon Steinbeiss editbugs 2020-03-28 16:04:22 CET
Please leave it open until I push the session fix.

Thanks a bunch for fixing this Sean!!
Comment 15 Git Bot editbugs 2020-03-28 22:09:33 CET
Simon Steinbeiss referenced this bugreport in commit 0c4496b3c989e5e200afb0abd7f61ff65f1bebc8

Add support for xfce4-screensaver (Bug #16522)

https://git.xfce.org/xfce/xfce4-session/commit?id=0c4496b3c989e5e200afb0abd7f61ff65f1bebc8
Comment 16 Git Bot editbugs 2020-03-28 22:10:34 CET
Simon Steinbeiss referenced this bugreport in commit 3faf52e8d61db5770499d454e54981a70e60d1b5

Add support for xfce4-screensaver (Bug #16522)

https://git.xfce.org/xfce/xfce4-session/commit?id=3faf52e8d61db5770499d454e54981a70e60d1b5
Comment 17 Simon Steinbeiss editbugs 2020-03-29 00:51:36 CET
Fixed with xfce4-session 4.14.2, xfce4-power-manager 1.6.6 and xfce4-screensaver from git master :)
Comment 18 Rinat 2020-04-04 21:35:41 CEST
*** Bug 16605 has been marked as a duplicate of this bug. ***

Bug #16522

Reported by:
Maurizio Galli
Reported on: 2020-03-10
Last modified on: 2020-04-04
Duplicates (1):
  • 16605 Xfce4-screensaver doesn't reply to "Lock" D-Bus method call which makes xfce4-power-manager grumpy

People

Assignee:
Ali Abdallah
CC List:
11 users

Version

Attachments

Proposed patch (1.75 KB, patch)
2020-03-10 08:55 CET , Maurizio Galli
no flags
xfce4-power-manager log (7.23 KB, application/octet-stream)
2020-03-10 10:49 CET , Maurizio Galli
no flags
xfce4-screensaver log during lid events (22.39 KB, text/plain)
2020-03-10 10:53 CET , Maurizio Galli
no flags
xfce-power-manager-log (8.05 KB, text/plain)
2020-03-11 18:21 CET , laguna
no flags
xfce4-screensaver log during lid events (15.42 KB, text/plain)
2020-03-11 19:02 CET , laguna
no flags
error message (10.12 KB, image/png)
2020-03-12 10:26 CET , Frash
no flags
xfce4-session: Support xfce4-screensaver (3.02 KB, patch)
2020-03-24 00:27 CET , Simon Steinbeiss
no flags

Additional information