! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Merging style and icons tabs into a theme tab
Status:
RESOLVED: MOVED
Severity:
enhancement
Product:
Xfce4-settings
Component:
Appearance Settings

Comments

Description Yousuf 'Jay' Philips 2020-03-04 05:13:19 CET
Created attachment 9532 
how it will look

Rather than users having to jump between tabs to finalize tweaking of their theme, we merge the style and icon tabs into a theme tab.
Comment 1 Yousuf 'Jay' Philips 2020-03-04 05:14:56 CET
Created attachment 9533 
the patch

Assume there maybe some small adjustments that are needed
Comment 2 Simon Steinbeiss editbugs 2020-03-08 23:41:41 CET
This doesn't look great to be honest.

While it brings the benefit of having the theme and the icons on one page, you end up with tiny scrolledwindows that don't show much of their content. So from an a11y pov this is really --

Also, what would be the argument of merging those two tabs and not "Icons" and "Fonts"? or "Style" and "Icons" and "Fonts"?
Comment 3 Yousuf 'Jay' Philips 2020-03-09 01:24:33 CET
(In reply to Simon Steinbeiss from comment #2)
> This doesn't look great to be honest.

Definitely could look better if the icon listbox showed a single line rather than 2 lines, like the style listbox.

> While it brings the benefit of having the theme and the icons on one page,
> you end up with tiny scrolledwindows that don't show much of their content.
> So from an a11y pov this is really --

From a UX perspective, users will want to change both of these when they are changing the theme and it isnt a good experience for them to have to constantly jump between the tabs to find the right icon and style combination they are looking for.

> Also, what would be the argument of merging those two tabs and not "Icons"
> and "Fonts"? or "Style" and "Icons" and "Fonts"?

Fonts has anti-aliasing and dpi settings which aren't theme related.
Comment 4 Yousuf 'Jay' Philips 2020-03-16 09:48:29 CET
Created attachment 9611 
icon list with 2 and 1 line per entry

I've seen the phrase 'UI Controls' and 'UI Elements' used which would be better than 'Window Internal Decorations'.

In order to make it easier to see more entries in the Icons list, each entry should be reduced from 2 lines to a single line.
Comment 5 Yousuf 'Jay' Philips 2020-03-19 14:35:56 CET
Mate uses 'Controls' as the tab name in its theme customization dialog.
http://askcaty.com/wp-content/uploads/2019/03/Mate-Desktop-Controls.png
Comment 6 Yousuf 'Jay' Philips 2020-04-10 16:06:18 CEST
'User Interface' might be a good alternative, when looking at the theme docs.
https://wiki.xfce.org/howto/install_new_themes#gtk_interfaces
Comment 7 Dmitry 2020-04-16 20:28:50 CEST
Created attachment 9731 
new appearance
Comment 8 Simon Steinbeiss editbugs 2020-05-28 18:05:37 CEST
*** Bug 16699 has been marked as a duplicate of this bug. ***
Comment 9 Git Bot editbugs 2020-05-28 23:17:13 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/xfce4-settings/-/issues/159.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #16500

Reported by:
Yousuf 'Jay' Philips
Reported on: 2020-03-04
Last modified on: 2020-05-28
Duplicates (1):

People

Assignee:
Xfce Bug Triage
CC List:
2 users

Version

Version:
4.15.0

Attachments

how it will look (33.93 KB, image/jpeg)
2020-03-04 05:13 CET , Yousuf 'Jay' Philips
no flags
the patch (10.44 KB, patch)
2020-03-04 05:14 CET , Yousuf 'Jay' Philips
no flags
icon list with 2 and 1 line per entry (53.20 KB, image/png)
2020-03-16 09:48 CET , Yousuf 'Jay' Philips
no flags
new appearance (137.04 KB, image/png)
2020-04-16 20:28 CEST , Dmitry
no flags

Additional information