! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Fallback timer only used to toggle monitor on/off
Status:
RESOLVED: FIXED
Severity:
critical
Product:
Xfce4-settings
Component:
Display Settings

Comments

Description alexxcons editbugs 2020-02-28 23:52:53 CET
Today I mounted a new grapic card at work, and I wanted to test which resolution fits best for my single monitor.

Unfortunately I forgot to set a proper update-rate for the monitor. I pressed "accept",  resulting in a black screen, and no possibility to switch back to a valid configuration via GUI.

I went to trial & error mode, removed ~/.config/xfce4/xfconf/xfce-perchannel-xml/displays.xml by chance and rebootet the system .. that helped .. phew.
 ...  something a newbe would not be able to do. Thats why I would rate that bug "critical".  

Actually I would expect the fallback timer to couver such a use case, so that I dont need to do console magic.

If you agree that we should have the fallback time as well on "accept" ( Thats the correct translation? It's "übernehmen" in german), than I would provide a patch.
Comment 1 Theo Linkspfeifer editbugs 2020-02-29 11:42:09 CET
Apparently, this was implemented long time ago, but somehow the code got lost? Bug 867
Comment 2 alexxcons editbugs 2020-03-02 18:12:07 CET
Possible .. for switching monitors on/off, the timer still exists. So I assume that at some point someone forgot to keep it as well for the "accept" button.

Thanks for digging up that patch !
Comment 3 alexxcons editbugs 2020-03-15 01:40:38 CET
Created attachment 9601 
patch to bring the feature back

Actually the "fallback" which is currently done via "toggle on/off" just corrupts the current monitor config.

So I fixed it for "apply" and "toggle on/off"
Comment 4 Git Bot editbugs 2020-03-30 00:51:01 CEST
Alexander Schwinn referenced this bugreport in commit 3b234ceb00fe5916fe5cc047b75239c383441a9c

Use proper fallback configuration on "apply" and "toggle off" (Bug #16476)

https://git.xfce.org/xfce/xfce4-settings/commit?id=3b234ceb00fe5916fe5cc047b75239c383441a9c
Comment 5 Git Bot editbugs 2020-03-30 00:51:54 CEST
Alexander Schwinn referenced this bugreport in commit d78ac6942eb1c13d6c23cee11a911aa7456babcf

Use proper fallback configuration on "apply" and "toggle off" (Bug #16476)

https://git.xfce.org/xfce/xfce4-settings/commit?id=d78ac6942eb1c13d6c23cee11a911aa7456babcf
Comment 6 alexxcons editbugs 2020-03-30 00:53:36 CEST
pushed to master and 4.14, will be released in "4.14.3" soon

Bug #16476

Reported by:
alexxcons
Reported on: 2020-02-28
Last modified on: 2020-03-30

People

Assignee:
alexxcons
CC List:
0 users

Version

Version:
4.15.0

Attachments

patch to bring the feature back (3.88 KB, patch)
2020-03-15 01:40 CET , alexxcons
no flags

Additional information