! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Garcon does not correctly detect menu type
Status:
RESOLVED: MOVED

Comments

Description Michael Perlov 2020-02-19 17:08:54 CET
Hi,
according to Desktop Menu Spec, default merge dir for applications menu is always $XDG_CONFIG_DIRS/menus/applications-merged/:

"Note that a system that uses either gnome-applications.menu or kde-applications.menu depending on the desktop environment in use must still use applications-merged as the default merge directory in both cases."
https://specifications.freedesktop.org/menu-spec/menu-spec-latest.html#paths

Currently, If $XDG_MENU_PREFIX+"applications.menu" != base menu filename, menu is not considered as application one, thus default merge directory is not used.
https://github.com/xfce-mirror/garcon/blob/fbb2d43f48a99d5b8378a0d95f7131ff8f22877b/garcon/garcon-menu-merger.c#L510
https://github.com/xfce-mirror/garcon/blob/fbb2d43f48a99d5b8378a0d95f7131ff8f22877b/garcon/garcon-menu-merger.c#L518

For example, I'm using awesome wm, so XDG_MENU_PREFIX is not set, but I want to use awesome-applications.menu as root menu.
Garcon will use "awesome-applications-merged" as default merge directory, which does not exist, so no additional categories will be merged.

Instead, garcon should check if menu file name ends with 'applications.menu'
If I understand specs correctly, XDG_MENU_PREFIX is used to find root menu file automatically, not to detect menu type.

Thanks.
Comment 1 Git Bot editbugs 2020-05-25 22:49:06 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/garcon/-/issues/12.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #16457

Reported by:
Michael Perlov
Reported on: 2020-02-19
Last modified on: 2020-05-25

People

Assignee:
Xfce Bug Triage
CC List:
0 users

Version

Version:
unspecified

Attachments

Additional information