! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
brightness control changes wrong backlight on hybrid GPU laptop
Status:
RESOLVED: MOVED
Product:
Xfce4-power-manager
Component:
General

Comments

Description Dan Robinson 2020-02-11 02:38:27 CET
I'm on a Thinkpad T530 which is an Optimus setup.

There are two backlight providers:

/sys/class/backlight/intel_backlight
/sys/class/backlight/nv_backlight

Both are type raw.

Only intel_backlight controls the actual brightness of the screen.

gnome-settings-daemon works correctly on my hardware. They seem to be checking if *_backlight/device/enabled is actually reading "enabled" and using that one. As best I can tell, in xfpm-backlight-helper.c it's just looping through all of the available interfaces and picking the last one that shows up (in this case, nv_backlight which is alphabetically last and also wrong).

Unfortunately I don't know enough about gobject and udev to write an actual *good* patch that's submitted, but if we can check for device/enabled == "enabled" and use that instead of just looping through them that should fix the issue.
Comment 1 Git Bot editbugs 2020-05-27 01:48:25 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/xfce4-power-manager/-/issues/74.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #16441

Reported by:
Dan Robinson
Reported on: 2020-02-11
Last modified on: 2020-05-27

People

Assignee:
Ali Abdallah
CC List:
3 users

Version

Attachments

Additional information